Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression fix: tokenize features earlier in window.open() #3108

Merged
merged 2 commits into from
Oct 9, 2017
Merged

Regression fix: tokenize features earlier in window.open() #3108

merged 2 commits into from
Oct 9, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Oct 9, 2017

Regressed in a68a1f7.

Fixes #3107.

@annevk
Copy link
Member Author

annevk commented Oct 9, 2017

I pushed a second commit for another regression in this algorithm. I think they are best as separate commits.

@annevk annevk mentioned this pull request Oct 9, 2017
Closed
@domenic domenic merged commit e1533f1 into master Oct 9, 2017
@domenic domenic deleted the annevk/tokenize-on-time branch October 9, 2017 17:40
@bzbarsky
Copy link
Contributor

bzbarsky commented Oct 9, 2017

Fwiw, browsers need to know the features to determine the target browsing context.

@domenic
Copy link
Member

domenic commented Oct 9, 2017

Hmm, maybe should have waited for @bzbarsky's review, sorry :-/

@annevk
Copy link
Member Author

annevk commented Oct 9, 2017

I think it's okay since we've restored the status quo. We have #1902 and #2464 to figure out how to improve this setup further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: frames/navigables/browsing contexts
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @bzbarsky @domenic