-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove noopener from tokenizedFeatures #3297
Conversation
So given #1902 (comment) I guess with this fix it would still be good to have tests and implementation bugs. Do you know if we have tests? |
I think CSSOM View still needs a fix for https://www.w3.org/Bugs/Public/show_bug.cgi?id=25722 / #2464 for this change to make a difference. I see these tests for noopener, but I think the tests we have don't check for "tab" vs "window". https://github.com/w3c/web-platform-tests/blob/master/html/browsers/the-window-object/window-open-noopener.html |
Otherwise CSSOM will assume it's more than a new window. Helps with #1902. Tests: ...
89f0080
to
7bf5809
Compare
I've made this account for noreferrer as well now. And I landed some tests for BarProp stuff, but unfortunately those don't seem to do the trick in Chrome. |
I think I'd be okay with landing this given that there's now some tests, even though they don't quite show the issue in Chrome yet (they will after a bug is fixed). @bzbarsky what do you think, does this improve the status quo even if the CSSOM bits aren't done? Should there be another test that compares non-BarProp aspects of the windows, e.g., viewport width or height? |
I think this does improve things even without the CSSOM bits. Doing a test that compares innerWidth/innerHeight and outerWidth/outerHeight with the "known good" window does seem like a good idea. |
…opener/noreferrer, a=testonly Automatic update from web-platform-tests HTML: ensure BarProps are visible for noopener/noreferrer For whatwg/html#3297. -- wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac wpt-pr: 16330
…/noreferrer, a=testonly Automatic update from web-platform-tests HTML: compare window sizing for noopener/noreferrer For whatwg/html#3297. -- wpt-commits: ec1d6a114188765744910ed4dfc63fc1fa4ca2c6 wpt-pr: 16658
…opener/noreferrer, a=testonly Automatic update from web-platform-tests HTML: ensure BarProps are visible for noopener/noreferrer For whatwg/html#3297. -- wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac wpt-pr: 16330
…/noreferrer, a=testonly Automatic update from web-platform-tests HTML: compare window sizing for noopener/noreferrer For whatwg/html#3297. -- wpt-commits: ec1d6a114188765744910ed4dfc63fc1fa4ca2c6 wpt-pr: 16658
…opener/noreferrer, a=testonly Automatic update from web-platform-tests HTML: ensure BarProps are visible for noopener/noreferrer For whatwg/html#3297. -- wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac wpt-pr: 16330 UltraBlame original commit: 5e1ab479dde3882aa3d4661a4f3336df60d8dec8
…opener/noreferrer, a=testonly Automatic update from web-platform-tests HTML: ensure BarProps are visible for noopener/noreferrer For whatwg/html#3297. -- wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac wpt-pr: 16330 UltraBlame original commit: 5e1ab479dde3882aa3d4661a4f3336df60d8dec8
…opener/noreferrer, a=testonly Automatic update from web-platform-tests HTML: ensure BarProps are visible for noopener/noreferrer For whatwg/html#3297. -- wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac wpt-pr: 16330 UltraBlame original commit: 5e1ab479dde3882aa3d4661a4f3336df60d8dec8
Apparently CSSOM needs to react differently if it's there.
Helps with #1902.
/infrastructure.html ( diff )
/window-object.html ( diff )