document.open(): only abort when there is a navigation #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the "ideal 2" plan in whatwg#3651, which is found to be compatible with the existing Chrome test suite. Closes whatwg#3651. Fixes whatwg#3975. Tests: web-platform-tests/wpt#10789
domenic
requested changes
Sep 4, 2018
Address some comments
domenic
approved these changes
Sep 6, 2018
19 tasks
TimothyGu
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 6, 2018
For whatwg/html#3999. Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 10, 2018
Currently, we have different behaviors for the "having a provisional document loader" state versus the "having a queued navigation" state. In the first case, we call FrameLoader::StopAllLoaders(), which cancels the ongoing navigation as well as fetches on the current page (e.g. XMLHttpRequest). In the second, we merely cancel the task to navigate, but do NOT cancel fetches. Indeed, it is recognized that the spec is currently unclear about canceling queued navigation vs. direct navigation (see [1]). However, it is worth noting that Chrome does not always follow the spec with this distinction in the first place (through location.href, for example, which queues a navigation task in Chrome but navigates directly in spec). Additionally, since even the current code cancels navigation in both circumstances (the only disagreement being if peripheral fetches are also canceled), we see no reason to have an inconsistency in this regard (see [2]). This CL now always calls FrameLoader::StopAllLoaders(), for both when we have a provisional loader and when we have a queued navigation, thus ridding ourselves of the inconsistency. By doing so, we implement the "ideal 2" plan laid out in [2], which recently became part of the HTML Standard in [3]. Tests for this new behavior (which this CL fully passes) are in [4], which was imported into our tree by the WPT Importer bot, whose expectations this CL now change. [1]: whatwg/html#3447 [2]: whatwg/html#3975 [3]: whatwg/html#3999 [4]: web-platform-tests/wpt#10789 Bug: 866274 Change-Id: I4e3ffac6b7c07bc8da812f6f210ab5d6933bdfd1 Reviewed-on: https://chromium-review.googlesource.com/1195837 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#590011}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 12, 2018
…ents, a=testonly Automatic update from web-platform-testsHTML: document.open() and aborting documents (#10789) For whatwg/html#3999. Co-authored-by: Anne van Kesteren <annevk@annevk.nl> -- wpt-commits: 2c6612a9b0f67c95fc8cc772cfecc2c1d435d75d wpt-pr: 10789 --HG-- rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/resources/slow.py => testing/web-platform/tests/common/slow.py
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Sep 12, 2018
…ents, a=testonly Automatic update from web-platform-testsHTML: document.open() and aborting documents (#10789) For whatwg/html#3999. Co-authored-by: Anne van Kesteren <annevk@annevk.nl> -- wpt-commits: 2c6612a9b0f67c95fc8cc772cfecc2c1d435d75d wpt-pr: 10789
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
This was missed in whatwg#3999.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
This was missed in whatwg#3999.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…ents, a=testonly Automatic update from web-platform-testsHTML: document.open() and aborting documents (#10789) For whatwg/html#3999. Co-authored-by: Anne van Kesteren <annevkannevk.nl> -- wpt-commits: 2c6612a9b0f67c95fc8cc772cfecc2c1d435d75d wpt-pr: 10789 UltraBlame original commit: b5ebc86c7bce94cf27b6d03c84ca8282ca285519
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…ents, a=testonly Automatic update from web-platform-testsHTML: document.open() and aborting documents (#10789) For whatwg/html#3999. Co-authored-by: Anne van Kesteren <annevkannevk.nl> -- wpt-commits: 2c6612a9b0f67c95fc8cc772cfecc2c1d435d75d wpt-pr: 10789 UltraBlame original commit: b5ebc86c7bce94cf27b6d03c84ca8282ca285519
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ents, a=testonly Automatic update from web-platform-testsHTML: document.open() and aborting documents (#10789) For whatwg/html#3999. Co-authored-by: Anne van Kesteren <annevkannevk.nl> -- wpt-commits: 2c6612a9b0f67c95fc8cc772cfecc2c1d435d75d wpt-pr: 10789 UltraBlame original commit: b5ebc86c7bce94cf27b6d03c84ca8282ca285519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the "ideal 2" plan in #3975, which is found to be compatible with the existing Chrome test suite.
Closes #3651.
Fixes #3975.
Tests: web-platform-tests/wpt#10789
/browsing-the-web.html ( diff )
/dynamic-markup-insertion.html ( diff )
/window-object.html ( diff )