Do not run FinishDynamicImport steps in parallel #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit looks good, but I can't approve it in isolation. |
|
You can approve the PR on the assumption that I'll do the right thing when it comes to merging... |
|
I'm going to reverse the order as per #3295 (comment) and testing discussions #4181 is going to get a bit more complicated. So, land only the second commit of this one first. |
These steps do a variety of things that only make sense back on the main thread. The intention here was that fetching not block the main thread. However, that is already the case even without going in parallel, given the "async algorithm" framework of the script-fetching algorithms. (That framework is admittedly a bit unclear; see whatwg/infra#181.)
domenic
force-pushed
the
finish-dynamic-import
branch
from
8c99a14 to
adf732f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These steps do a variety of things that only make sense back on the main thread.
The intention here was that fetching not block the main thread. However, that is
already the case even without going in parallel, given the "async algorithm"
framework of the script-fetching algorithms. (That framework is admittedly a bit
unclear; see whatwg/infra#181.)
This is on top of #4181; please only review the second commit. If it turns out #4181 is going to take a while to land (e.g. due to tests) then I can rearrange the commits.