Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mostly-editorial cleanups to script execution #5154

Merged
merged 5 commits into from
Jan 9, 2020
Merged

Mostly-editorial cleanups to script execution #5154

merged 5 commits into from
Jan 9, 2020

Commits on Dec 13, 2019

  1. Cleanups to "execute a script block" 

    One normative fix: by saving the script element's node document before
evaluation, this properly changes that document's currentScript back
after evaluation. As previously written, a script that moved during
evaluation would cause its new node document's currentScript to update.

Tests: web-platform-tests/wpt#20775

Editorial cleanups:

* Use a named argument, scriptElement
* Use the saved document variable throughout
* Cleanup source formatting
* Remove <!-- SCRIPT EXEC --> comments
    @domenic
    domenic committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    6789eec View commit details
    Browse the repository at this point in the history

  2. Editorial: add explicit "parser document" to script elements 

    Previously this was referenced in an implicit way, as "the parser that
created the element". This makes it an explicit associated value, from
which "parser-inserted" is derived.
    @domenic
    domenic committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    d8a94ba View commit details
    Browse the repository at this point in the history

  3. Editorial: stop numbering the script-element pieces of state 

    This makes it easier to add to and rearrange them.
    @domenic
    domenic committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    24dba60 View commit details
    Browse the repository at this point in the history

  4. Editorial: add explicit "preparation-time document" to script elements 

    Previously this was referred to imprecisely as "the node document of the
script element at the time the prepare a script algorithm started".
    @domenic
    domenic committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    bca3108 View commit details
    Browse the repository at this point in the history

  5. Signpost the debate on some script document mismatches 

    This adds a pointer to #2137, which remains somewhat contested, to the
relevant parts of the prepare and execute algorithms for scripts.
    @domenic
    domenic committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    0f588ac View commit details
    Browse the repository at this point in the history