Align with DOM DocumentFragment adoption changes #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Mar 30, 2020
There was a problem hiding this comment.
Thoughts on how to pass boolean variables? I wish we had a better pattern for them.
I don't like using <var> for something that is never "let" or "set". Any of the following would be reasonable to me:
- "into doc, with true" (or "passing true")
- "into doc, with [force document fragment adoption] set to true", where that's a link to a
<dfn> - "into doc, with true for the the force document fragment adoption parameter" (no link)
|
Addressed feedback, but whatwg/html-build#218 is happening now. |
domenic
approved these changes
Mar 31, 2020
rniwa
reviewed
Jul 2, 2022
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Oct 18, 2022
Tests: web-platform-tests/wpt#22504. Corresponding HTML PR: whatwg/html#5413. Closes #813 and closes #814.
annevk
force-pushed
the
annevk/dom-adopt
branch
from
b62bbc7
to
b4ec415
Compare
mfreed7
reviewed
Nov 11, 2022
| <li><p><span data-x="concept-node-adopt">Adopt</span> <var>node</var>'s | ||
| <span>template contents</span> (a <code>DocumentFragment</code> object) into <var>doc</var>.</p></li> | ||
| <li><p><span data-x="concept-node-adopt">Adopt</span> <var>node</var>'s <span>template | ||
| contents</span> into <var>doc</var>, with true.</p></li> |
There was a problem hiding this comment.
This change (adding , with true) is ok by me. But there seems to be a compat issue with the more general change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements whatwg/dom#819.
Thoughts on how to pass boolean variables? I wish we had a better pattern for them.
(See WHATWG Working Mode: Changes for more details.)
/scripting.html ( diff )