Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow an image to indicate its own density and correct its intrinsic size #5574

Merged
merged 16 commits into from
Jul 8, 2021
Merged

Allow an image to indicate its own density and correct its intrinsic size #5574

merged 16 commits into from
Jul 8, 2021

Commits on Jun 27, 2021

  1. Allow an image to indicate its own density and correct its intrinsic … 

    …size.

See https://discourse.wicg.io/t/proposal-exif-image-resolution-auto-and-from-image/4326/24

This proposal allows using EXIF or other metadata to determine an image's
default resolution, which may be different from the requested resolution
in srcset/image-set, or from the default of 1dppx.

The use-case is, for example, allowing serving low-density placeholder in poor
network conditions without affecting layout.

When an image indicates its intrinsic density-corrected size, that indication
is "stronger" than the requested density (current pixel density). This allows, for example, serving a regular 1x image when a 2x image is requested by srcset, allowing for correct presentation of content that contains that information.

The WICG proposal defines that in detail - using size+resolution from EXIF
when their values are matching.
    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    978645b View commit details
    Browse the repository at this point in the history

  2. Use image request, refactor to use 'prepare' algo

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    08e4a01 View commit details
    Browse the repository at this point in the history

  3. nit

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    a0ff979 View commit details
    Browse the repository at this point in the history

  4. Fix CR comments

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    9c1e85e View commit details
    Browse the repository at this point in the history

  5. Bail from metadata reading for non-origin-clean images

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    873dfb5 View commit details
    Browse the repository at this point in the history

  6. Apply same-origin clarifications after whatwg#5165

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    7f09870 View commit details
    Browse the repository at this point in the history

  7. Nit req/img

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    cd6d4db View commit details
    Browse the repository at this point in the history

  8. Declare an img pointing to img's req

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    84fce1d View commit details
    Browse the repository at this point in the history

  9. Use better terms for cross-origin

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    71af446 View commit details
    Browse the repository at this point in the history

  10. More nits

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    fc718c4 View commit details
    Browse the repository at this point in the history

  11. Fix typo px -> pt

    @zcorpan @noamr
    zcorpan authored and noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    00b5724 View commit details
    Browse the repository at this point in the history

  12. Fix source formatting

    @zcorpan @noamr
    zcorpan authored and noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    9f5e047 View commit details
    Browse the repository at this point in the history

  13. Apply review comments

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    98ccb1d View commit details
    Browse the repository at this point in the history

  14. Apply review comments

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    550cd15 View commit details
    Browse the repository at this point in the history

  15. CR comments

    @noamr
    noamr committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    da9f571 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Fix wrong variable references (img does not exist at the call sites) … 

    …and other issues
    @domenic
    domenic committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    441ca72 View commit details
    Browse the repository at this point in the history