Expose Worker and SharedWorker less #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests: web-platform-tests/wpt#23381. Closes #5497.
domenic
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
LGTM with some punctuation changes I suggest while we're in the area. A bit surprised this doesn't allow any simplification, but I guess that's believable.
I'm a bit surprised nobody allows creating Workers from a service worker, even Firefox. It seems like it'd be pretty useful to avoid janking your networking.
|
@asutherland found #411 (and w3c/ServiceWorker#678 before that). I guess we should keep that open in case folks are motivated to add it again. |
|
I missed that https://bugs.chromium.org/p/chromium/issues/detail?id=1088481 is filed. So this is blocking on test review. |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 3, 2020
And remove broken tests. For whatwg/html#5601.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 13, 2020
…are exposed, a=testonly Automatic update from web-platform-tests Workers: test where Worker/SharedWorker are exposed And remove broken tests. For whatwg/html#5601. -- wpt-commits: 84d101a169cf21f345a5c3bd39f27b919a16195b wpt-pr: 23381
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 13, 2020
…are exposed, a=testonly Automatic update from web-platform-tests Workers: test where Worker/SharedWorker are exposed And remove broken tests. For whatwg/html#5601. -- wpt-commits: 84d101a169cf21f345a5c3bd39f27b919a16195b wpt-pr: 23381
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 15, 2020
…are exposed, a=testonly Automatic update from web-platform-tests Workers: test where Worker/SharedWorker are exposed And remove broken tests. For whatwg/html#5601. -- wpt-commits: 84d101a169cf21f345a5c3bd39f27b919a16195b wpt-pr: 23381 UltraBlame original commit: 4a481dca84b353425398a139ba7570d62a907209
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 15, 2020
…are exposed, a=testonly Automatic update from web-platform-tests Workers: test where Worker/SharedWorker are exposed And remove broken tests. For whatwg/html#5601. -- wpt-commits: 84d101a169cf21f345a5c3bd39f27b919a16195b wpt-pr: 23381 UltraBlame original commit: 4a481dca84b353425398a139ba7570d62a907209
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 15, 2020
…are exposed, a=testonly Automatic update from web-platform-tests Workers: test where Worker/SharedWorker are exposed And remove broken tests. For whatwg/html#5601. -- wpt-commits: 84d101a169cf21f345a5c3bd39f27b919a16195b wpt-pr: 23381 UltraBlame original commit: 4a481dca84b353425398a139ba7570d62a907209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: web-platform-tests/wpt#23381.
Closes #5497.
This allowed for no simplification whatsoever, but it still seems like a good change to make after all these years.
(See WHATWG Working Mode: Changes for more details.)
/workers.html ( diff )