Obsolete <object usemap> #6283

annevk · 2021-01-12T10:50:41Z

It does not appear to be implemented by Chrome or Safari, except for the fact that it makes object interactive.

At least two implementers are interested (and none opposed):
- Presumably all of them?
Tests are written and can be reviewed and commented upon at:
- Remove "usemap" attribute from <object> web-platform-tests/wpt#27830
- More changes related to removal of <object usemap> web-platform-tests/wpt#27864
Implementation bugs are filed:
- Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1182910
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=392994
- Safari: https://bugs.webkit.org/show_bug.cgi?id=222642

(See WHATWG Working Mode: Changes for more details.)

/dom.html ( diff )
/iframe-embed-object.html ( diff )
/image-maps.html ( diff )
/indices.html ( diff )
/obsolete.html ( diff )

domenic

Some content model stuff is wrong, I think, but otherwise very nice catch.

source

domenic · 2021-01-12T15:45:28Z

source

@@ -116901,6 +116887,10 @@ interface <dfn>HTMLFontElement</dfn> : <span>HTMLElement</span> {
  <code>object</code> element must <span>reflect</span> the element's <code
  data-x="attr-object-codetype">codetype</code> content attribute.</p>

+  <p>The <dfn><code data-x="dom-object-useMap">useMap</code></dfn> IDL attribute of the
+  <code>object</code> element must <span>reflect</span> the element's <code
+  data-x="attr-object-usemap">usemap</code> content attribute.</p>


To confirm, this part is implemented in Chrome (and probably inherited from Safari).

source

Tests for whatwg/html#6283.

annevk · 2021-01-14T10:05:34Z

@cdumez @mfreed7 per web-platform-tests/wpt#27184 it seems there is some <object usemap> support in Chrome/Safari after all. Is there interest in cleaning this up or should we try to enshrine that somehow? I assume there is no interest in supporting image maps for the object element more generally.

mfreed7 · 2021-02-26T23:25:57Z

As I just commented, I'm supportive of removing <object usemap> entirely. In Chromium, this does nothing other than make the element interactive. I'd be inclined to just land this change soon (we just branched a new version) and see if there are any bug reports.

This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] #27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13

It does not appear to be implemented by Chrome or Safari.

This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] #27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13

This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] #27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634}

This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634}

annevk · 2021-03-03T08:07:25Z

I filed #6434 on the difference between embed and object here. I'm okay with landing this, but I'm also happy to wait until Chrome declares it a success.

… a=testonly Automatic update from web-platform-tests Remove "usemap" attribute from <object> This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634} -- wpt-commits: 92dd8581875d162e26c2951666e8eeeba828f4d6 wpt-pr: 27830

… a=testonly Automatic update from web-platform-tests Remove "usemap" attribute from <object> This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreedchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Auto-Submit: Mason Freed <masonfreedchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/master{#858634} -- wpt-commits: 92dd8581875d162e26c2951666e8eeeba828f4d6 wpt-pr: 27830 UltraBlame original commit: 84a3cceb690bc31a2578da467f20e17ea702d13a

https://bugs.webkit.org/show_bug.cgi?id=222642 LayoutTests/imported/w3c: Reviewed by Antti Koivisto. As per whatwg/html#6283, <object usemap> should no longer be supported. IDL support is kept per spec like other obsolete attributes. * web-platform-tests/html/semantics/forms/the-label-element/clicking-noninteractive-unlabelable-content-expected.txt: Source/WebCore: Reviewed by Antti Koivisto. As per whatwg/html#6283, <object usemap> should no longer be supported. IDL support is kept per spec like other obsolete attributes. * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isURLAttribute const): (WebCore::HTMLObjectElement::addSubresourceAttributeURLs const): (WebCore::HTMLObjectElement::isInteractiveContent const): Deleted. * html/HTMLObjectElement.h: Source/WebKit: Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-11-11 Reviewed by Antti Koivisto. Remove support for usemap attribute in GTK DOM API adding a warning message instead. * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLObjectElement.cpp: (webkit_dom_html_object_element_get_use_map): (webkit_dom_html_object_element_set_use_map): LayoutTests: Reviewed by Antti Koivisto. As per whatwg/html#6283, <object usemap> should no longer be supported. IDL support is kept per spec like other obsolete attributes. * imported/blink/fast/forms/label/label-contains-other-interactive-content-expected.txt: * imported/blink/fast/forms/label/label-contains-other-interactive-content.html: Canonical link: https://commits.webkit.org/244139@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=222642 LayoutTests/imported/w3c: Reviewed by Antti Koivisto. As per whatwg/html#6283, <object usemap> should no longer be supported. IDL support is kept per spec like other obsolete attributes. * web-platform-tests/html/semantics/forms/the-label-element/clicking-noninteractive-unlabelable-content-expected.txt: Source/WebCore: Reviewed by Antti Koivisto. As per whatwg/html#6283, <object usemap> should no longer be supported. IDL support is kept per spec like other obsolete attributes. * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isURLAttribute const): (WebCore::HTMLObjectElement::addSubresourceAttributeURLs const): (WebCore::HTMLObjectElement::isInteractiveContent const): Deleted. * html/HTMLObjectElement.h: Source/WebKit: Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-11-11 Reviewed by Antti Koivisto. Remove support for usemap attribute in GTK DOM API adding a warning message instead. * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLObjectElement.cpp: (webkit_dom_html_object_element_get_use_map): (webkit_dom_html_object_element_set_use_map): LayoutTests: Reviewed by Antti Koivisto. As per whatwg/html#6283, <object usemap> should no longer be supported. IDL support is kept per spec like other obsolete attributes. * imported/blink/fast/forms/label/label-contains-other-interactive-content-expected.txt: * imported/blink/fast/forms/label/label-contains-other-interactive-content.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@285638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634} GitOrigin-RevId: 1d81c3837a4d38837f66fbeb5ace831ddbac3443

annevk added removal/deprecation Removing or deprecating a feature topic: embed and object labels Jan 12, 2021

domenic requested changes Jan 12, 2021

View reviewed changes

domenic approved these changes Jan 13, 2021

View reviewed changes

annevk force-pushed the annevk/object-usemap branch from 6d2aaad to 174fa71 Compare January 14, 2021 09:11

annevk added a commit to web-platform-tests/wpt that referenced this pull request Jan 14, 2021

HTML: <object usemap> is removed

64b5b6c

Tests for whatwg/html#6283.

annevk mentioned this pull request Jan 14, 2021

HTML: <object usemap> is removed web-platform-tests/wpt#27184

Closed

annevk added the do not merge yet Pull request must not be merged per rationale in comment label Jan 14, 2021

Base automatically changed from master to main January 15, 2021 07:58

past mentioned this pull request Feb 10, 2021

Upcoming HTML standard issue triage meeting on 3/4/2021 #6371

Closed

chromium-wpt-export-bot mentioned this pull request Mar 1, 2021

Remove "usemap" attribute from <object> web-platform-tests/wpt#27830

Merged

Obsolete <object usemap>

fd34400

It does not appear to be implemented by Chrome or Safari.

annevk force-pushed the annevk/object-usemap branch from 174fa71 to fd34400 Compare March 1, 2021 07:12

sideshowbarker added the impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation label Mar 1, 2021

annevk mentioned this pull request Mar 3, 2021

Investigate why object is not-interactive, but embed and iframe are #6434

Open

domenic merged commit 14ce057 into main Mar 3, 2021

domenic deleted the annevk/object-usemap branch March 3, 2021 15:55

domenic removed the do not merge yet Pull request must not be merged per rationale in comment label Mar 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Obsolete <object usemap> #6283

Obsolete <object usemap> #6283

annevk commented Jan 12, 2021 •

edited by pr-preview bot

Loading

domenic left a comment

domenic Jan 12, 2021

annevk commented Jan 14, 2021

mfreed7 commented Feb 26, 2021

annevk commented Mar 3, 2021

Obsolete <object usemap> #6283

Obsolete <object usemap> #6283

Conversation

annevk commented Jan 12, 2021 • edited by pr-preview bot Loading

domenic left a comment

Choose a reason for hiding this comment

domenic Jan 12, 2021

Choose a reason for hiding this comment

annevk commented Jan 14, 2021

mfreed7 commented Feb 26, 2021

annevk commented Mar 3, 2021

annevk commented Jan 12, 2021 •

edited by pr-preview bot

Loading