Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export link type manifest #6445

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Mar 4, 2021

Over on w3c/webref#114, we are trying to figure out what the best way to export these "link type X" might be.

Problem is that they were available in BikeShed/Shepherd, but currently Webref doesn't have them (so I've got some broken links over in the manifest spec).

Open suggestions on how to best export this.

Happy to do the others once we settle on something.


/links.html ( diff )

@marcoscaceres
Copy link
Member Author

FWIW, my preference would be:

<h5><dfn export data-lt="manifest">Link type "<code data-x="rel-manifest">manifest</code>"</dfn></h5>

So I can:

Continue to link to it like: [=link type "manifest"=]

@annevk
Copy link
Member

annevk commented Mar 4, 2021

I think we could use attr-value as per https://tabatkins.github.io/bikeshed/#dfn-types though since there's also the Link header this might call for a new type, such as linkrel or some such.

cc @tabatkins

@annevk annevk added the meta Changes to the ecosystem around the standard, not its contents label Mar 4, 2021
@domenic
Copy link
Member

domenic commented Mar 4, 2021

+1 for attr-value. Then you'd use for="link/rel".

@marcoscaceres
Copy link
Member Author

Ok, cool. This now matches "preload", which is exported in the same way.

@marcoscaceres
Copy link
Member Author

Let me know if you want me to export the other link types. I can send a separate PR for those if you'd like.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

I do think we should export all link types. This is a bit more complex because some should be for="link/rel", some should be for="a/rel", some should be for="a/rel,link/rel,form/rel", etc. See https://html.spec.whatwg.org/#linkTypes

Let me know if you want to do that in this PR, or in a followup! I'd slightly prefer a single PR but I don't want to block you if you have other work depending on this getting merged.

@marcoscaceres
Copy link
Member Author

If it's ok, I'd like to get this merged in first as it's currently affecting at least one spec.

I can follow up with the other exports as I think the ARIA in HTML spec also needs the exports you mentioned with the correct for= precision.

@domenic domenic merged commit d26cee5 into whatwg:main Mar 11, 2021
@marcoscaceres marcoscaceres deleted the export_link_manifest branch March 12, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Changes to the ecosystem around the standard, not its contents
Development

Successfully merging this pull request may close these issues.

3 participants