-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export link type manifest #6445
Conversation
FWIW, my preference would be: <h5><dfn export data-lt="manifest">Link type "<code data-x="rel-manifest">manifest</code>"</dfn></h5> So I can: Continue to link to it like: [=link type "manifest"=] |
I think we could use cc @tabatkins |
+1 for attr-value. Then you'd use for="link/rel". |
Ok, cool. This now matches |
Let me know if you want me to export the other link types. I can send a separate PR for those if you'd like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
I do think we should export all link types. This is a bit more complex because some should be for="link/rel"
, some should be for="a/rel"
, some should be for="a/rel,link/rel,form/rel"
, etc. See https://html.spec.whatwg.org/#linkTypes
Let me know if you want to do that in this PR, or in a followup! I'd slightly prefer a single PR but I don't want to block you if you have other work depending on this getting merged.
If it's ok, I'd like to get this merged in first as it's currently affecting at least one spec. I can follow up with the other exports as I think the ARIA in HTML spec also needs the exports you mentioned with the correct |
Over on w3c/webref#114, we are trying to figure out what the best way to export these "link type X" might be.
Problem is that they were available in BikeShed/Shepherd, but currently Webref doesn't have them (so I've got some broken links over in the manifest spec).
Open suggestions on how to best export this.
Happy to do the others once we settle on something.
/links.html ( diff )