Treat javascript: URL results as UTF-8 bytes #6781

domenic · 2021-06-16T21:27:47Z

Closes #1129.

At least two implementers are interested (and none opposed):
- Right now each browser does something different: Chrome implements this; Firefox does some sort of sniffing for windows-1252 characters only; and WebKit skips the bytes step and creates a document from a string
- Chrome implements this
- In javascript URL: define JS string-to-byte conversion better #1129 (comment) @annevk offered a semi-recommendation that we do this. Still up for it, @annevk?
Tests are written and can be reviewed and commented upon at:
- Update javascript: URL byte/string conversion tests web-platform-tests/wpt#29419
Implementation bugs are filed:
- Chrome: https://crbug.com/1221018
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1717678
- Safari: https://bugs.webkit.org/show_bug.cgi?id=227259

(See WHATWG Working Mode: Changes for more details.)

💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Jun 22, 2021, 5:09 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

<html>
<head><title>524 Origin Time-out</title></head>
<body bgcolor="white">
<center><h1>524 Origin Time-out</h1></center>
<hr><center>cloudflare-nginx</center>
</body>
</html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

domenic · 2021-06-16T21:36:58Z

No, wait, this doesn't match Chrome I think... let's continue discussion in #1129.

Follows whatwg/html#6781.

Closes #1129.

rniwa · 2021-06-17T04:29:02Z

@cdumez @achristensen07

Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from #29419. Co-authored-by: Domenic Denicola <domenic@chromium.org> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d

Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from #29419. Co-authored-by: Domenic Denicola <domenic@chromium.org> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#893876}

TimothyGu · 2021-06-21T21:45:05Z

Chrome now matches this PR fully after https://crrev.com/c/2967353 (Chrome 93).

annevk

Yeah, this still seems like a good idea.

whatwg/html#6781 got merged.

…ting javascript URLs, a=testonly Automatic update from web-platform-tests Replace unpaired surrogates after evaluating javascript URLs Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from web-platform-tests/wpt#29419. Co-authored-by: Domenic Denicola <domenic@chromium.org> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#893876} -- wpt-commits: ad7af3947f19693e8ab8911663a41152e907ed0e wpt-pr: 29422

…rsion tests, a=testonly Automatic update from web-platform-tests Un-.tentative javascript: byte handling test whatwg/html#6781 got merged. -- wpt-commits: 4465a5d5ffb1b89a7f9960fb614da2317c63e860 wpt-pr: 29419

…ting javascript URLs, a=testonly Automatic update from web-platform-tests Replace unpaired surrogates after evaluating javascript URLs Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from web-platform-tests/wpt#29419. Co-authored-by: Domenic Denicola <domenic@chromium.org> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#893876} -- wpt-commits: ad7af3947f19693e8ab8911663a41152e907ed0e wpt-pr: 29422

…rsion tests, a=testonly Automatic update from web-platform-tests Un-.tentative javascript: byte handling test whatwg/html#6781 got merged. -- wpt-commits: 4465a5d5ffb1b89a7f9960fb614da2317c63e860 wpt-pr: 29419

https://bugs.webkit.org/show_bug.cgi?id=232380 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT test now that more checks are passing. The remaining failures are due to the fact that we ignore the JavaScript URL result when the URL is set as href on an anchor (as opposed to the src of an iframe). This will be addressed separately. * web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic-expected.txt: Source/WebCore: JavaScript URL result should be treated as UTF-8 bytes: - whatwg/html#6781 No new tests, rebaselined existing test. * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocumentWithResultOfExecutingJavascriptURL): Canonical link: https://commits.webkit.org/243604@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=232380 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT test now that more checks are passing. The remaining failures are due to the fact that we ignore the JavaScript URL result when the URL is set as href on an anchor (as opposed to the src of an iframe). This will be addressed separately. * web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic-expected.txt: Source/WebCore: JavaScript URL result should be treated as UTF-8 bytes: - whatwg/html#6781 No new tests, rebaselined existing test. * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocumentWithResultOfExecutingJavascriptURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@284934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from web-platform-tests/wpt#29419. Co-authored-by: Domenic Denicola <domenic@chromium.org> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#893876} NOKEYCHECK=True GitOrigin-RevId: be9d85b1de10c87c8904ffcd650890e67d894119

domenic added topic: navigation topic: javascript: URLs labels Jun 16, 2021

domenic added a commit to web-platform-tests/wpt that referenced this pull request Jun 16, 2021

Update javascript: URL byte/string conversion tests

6f2e7e2

Follows whatwg/html#6781.

Treat javascript: URL results as UTF-8 bytes

0b99c86

Closes #1129.

domenic force-pushed the javascript-body branch from 9c881cf to 0b99c86 Compare June 16, 2021 21:43

domenic mentioned this pull request Jun 17, 2021

Update javascript: URL byte/string conversion tests web-platform-tests/wpt#29419

Merged

chromium-wpt-export-bot mentioned this pull request Jun 17, 2021

Replace unpaired surrogates after evaluating javascript URLs web-platform-tests/wpt#29422

Merged

annevk approved these changes Jun 22, 2021

View reviewed changes

domenic merged commit 66605d1 into main Jun 22, 2021

domenic deleted the javascript-body branch June 22, 2021 17:08

domenic added a commit to web-platform-tests/wpt that referenced this pull request Jun 22, 2021

Un-.tentative javascript: byte handling test

c26ddf0

whatwg/html#6781 got merged.

domenic added a commit to web-platform-tests/wpt that referenced this pull request Jun 22, 2021

Un-.tentative javascript: byte handling test

4465a5d

whatwg/html#6781 got merged.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Treat javascript: URL results as UTF-8 bytes #6781

Treat javascript: URL results as UTF-8 bytes #6781

domenic commented Jun 16, 2021 •

edited

Loading

domenic commented Jun 16, 2021

rniwa commented Jun 17, 2021 •

edited

Loading

TimothyGu commented Jun 21, 2021

annevk left a comment

Treat javascript: URL results as UTF-8 bytes #6781

Treat javascript: URL results as UTF-8 bytes #6781

Conversation

domenic commented Jun 16, 2021 • edited Loading

💥 Error: Wattsi server error 💥

domenic commented Jun 16, 2021

rniwa commented Jun 17, 2021 • edited Loading

TimothyGu commented Jun 21, 2021

annevk left a comment

Choose a reason for hiding this comment

domenic commented Jun 16, 2021 •

edited

Loading

rniwa commented Jun 17, 2021 •

edited

Loading