Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that we will not add new named character references #7071

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Note that we will not add new named character references #7071

merged 2 commits into from
Sep 20, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Sep 14, 2021 •
edited by pr-preview bot
Loading

Closes #3655. Closes #5121. Closes #6049.

/named-characters.html ( diff )

@domenic domenic requested a review from annevk September 17, 2021 19:50
annevk
annevk approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna say that this is not a question, but it seems this is the style we use for these. 😊 Nice summary!

@annevk
Copy link
Member

annevk commented Sep 20, 2021

Perhaps this should be prefixed with "Meta:"?

r12a
r12a reviewed Sep 20, 2021
View reviewed changes
FAQ.md Outdated Show resolved Hide resolved
@domenic
Copy link
Member Author

domenic commented Sep 20, 2021

Perhaps this should be prefixed with "Meta:"?

Eh, I feel anything that closes three issues is probably not so meta.

@domenic domenic merged commit ef29c39 into main Sep 20, 2021
@domenic domenic deleted the no-more-named-entities branch September 20, 2021 15:08
@past past mentioned this pull request Oct 11, 2021
Closed
@aphillips aphillips mentioned this pull request Mar 4, 2023
Open
@Crissov Crissov mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r12a r12a r12a left review comments

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
topic: parser
Milestone
No milestone
3 participants
@domenic @annevk @r12a