Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent modules from being imported with a type: 'javascript' assertion #7350

Merged
merged 10 commits into from
Nov 23, 2021
Merged

Prevent modules from being imported with a type: 'javascript' assertion #7350

merged 10 commits into from
Nov 23, 2021

Commits on Nov 19, 2021

  1. Prevent modules from being imported with a type: 'javascript' assertion.

    @dandclark
    dandclark committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    0b21a83 View commit details
    Browse the repository at this point in the history

  2. Clarify that null module type will cause module allowed check to fail

    @dandclark
    dandclark committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    1166785 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. module type --> moduleType

    @dandclark
    dandclark committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    8ed198c View commit details
    Browse the repository at this point in the history

  2. Convert another instance I missed to use 'module type from module req… 

    …uest'
    @dandclark
    dandclark committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    26d7fec View commit details
    Browse the repository at this point in the history

  3. Add explanatory note that JS type assertions fail

    @dandclark
    dandclark committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    0bcfc12 View commit details
    Browse the repository at this point in the history

  4. Typo fixes (it won't let me commit these directly on the PR UI)

    @dandclark
    dandclark committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    d888653 View commit details
    Browse the repository at this point in the history

  5. Add 'undefined' type assertion example

    @dandclark
    dandclark committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    64f5109 View commit details
    Browse the repository at this point in the history

  6. setting's --> settings's

    @dandclark
    dandclark committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    da0df92 View commit details
    Browse the repository at this point in the history

  7. Move example to module-map section. Give import/type <code> styling w… 

    …here appropriate.
    @dandclark
    dandclark committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    7adb68d View commit details
    Browse the repository at this point in the history

  8. Nit

    @domenic
    domenic committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    a7ff726 View commit details
    Browse the repository at this point in the history