Remove ErrorEventInit's error default #7983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that ErrorEvent has equivalent expressiveness to reportError(). Fixes #7853.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 3, 2022
This accounts for the change in whatwg/html#7983 as well.
This was referenced Jun 3, 2022
|
Patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1772494, I'll land that once the wpt tests have landed. |
annevk
commented
Jun 3, 2022
| @@ -94923,7 +94923,7 @@ dictionary <dfn dictionary>ErrorEventInit</dfn> : <span>EventInit</span> { | |||
| USVString filename = ""; | |||
| unsigned long lineno = 0; | |||
| unsigned long colno = 0; | |||
| any error = null; | |||
| any error; | |||
There was a problem hiding this comment.
If we're happy enough with the progress on whatwg/webidl#983 I can change this to = undefined instead and remove the prose change below.
annevk
force-pushed
the
annevk/erroreventinit
branch
from
21450b2
to
dd8bbaf
Compare
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 7, 2022
This accounts for the change in whatwg/html#7983 as well.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 10, 2022
…testonly Automatic update from web-platform-tests HTML: assert ErrorEventInit defaults This accounts for the change in whatwg/html#7983 as well. -- wpt-commits: c297f88500de105a82118d1a5527d52e63c7ba47 wpt-pr: 34297
webkit-early-warning-system
pushed a commit
to cdumez/WebKit
that referenced
this pull request
Jun 23, 2022
https://bugs.webkit.org/show_bug.cgi?id=241259 <rdar://94793559> Reviewed by Darin Adler. Update ErrorEventInit's error default to be undefined instead of null, as per: - whatwg/html#7983 * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html: * Source/WebCore/dom/ErrorEvent.cpp: (WebCore::ErrorEvent::error): * Source/WebCore/dom/ErrorEvent.idl: Canonical link: https://commits.webkit.org/251797@main
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 7, 2022
Per the spec change [1], this removes ErrorEventInit's default value of null, which makes the error attribute have no null default. This change has already shipped on WebKit and Gecko, and the change makes Chromium match the spec and other implementations. This is tested by this WPT: wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html [1] whatwg/html#7983 Fixed: 1332448 Change-Id: Ia64a62e8c5739ab278016a94b0c3b0419d6a68f6
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 7, 2022
Per the spec change [1], this removes ErrorEventInit's default value of null, which makes the error attribute have no null default. This change has already shipped on WebKit and Gecko, and the change makes Chromium match the spec and other implementations. This is tested by this WPT: wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html [1] whatwg/html#7983 Fixed: 1332448 Change-Id: Ia64a62e8c5739ab278016a94b0c3b0419d6a68f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749784 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021841}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 7, 2022
Per the spec change [1], this removes ErrorEventInit's default value of null, which makes the error attribute have no null default. This change has already shipped on WebKit and Gecko, and the change makes Chromium match the spec and other implementations. This is tested by this WPT: wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html [1] whatwg/html#7983 Fixed: 1332448 Change-Id: Ia64a62e8c5739ab278016a94b0c3b0419d6a68f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749784 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021841}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 7, 2022
Per the spec change [1], this removes ErrorEventInit's default value of null, which makes the error attribute have no null default. This change has already shipped on WebKit and Gecko, and the change makes Chromium match the spec and other implementations. This is tested by this WPT: wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html [1] whatwg/html#7983 Fixed: 1332448 Change-Id: Ia64a62e8c5739ab278016a94b0c3b0419d6a68f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749784 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021841}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 14, 2022
…ault value, a=testonly Automatic update from web-platform-tests Remove ErrorEventInit's error's null default value Per the spec change [1], this removes ErrorEventInit's default value of null, which makes the error attribute have no null default. This change has already shipped on WebKit and Gecko, and the change makes Chromium match the spec and other implementations. This is tested by this WPT: wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html [1] whatwg/html#7983 Fixed: 1332448 Change-Id: Ia64a62e8c5739ab278016a94b0c3b0419d6a68f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749784 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021841} -- wpt-commits: 824d27822a6c110981a6bbb99dddbcdf8455f56a wpt-pr: 34741
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Jul 15, 2022
…ault value, a=testonly Automatic update from web-platform-tests Remove ErrorEventInit's error's null default value Per the spec change [1], this removes ErrorEventInit's default value of null, which makes the error attribute have no null default. This change has already shipped on WebKit and Gecko, and the change makes Chromium match the spec and other implementations. This is tested by this WPT: wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html [1] whatwg/html#7983 Fixed: 1332448 Change-Id: Ia64a62e8c5739ab278016a94b0c3b0419d6a68f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749784 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021841} -- wpt-commits: 824d27822a6c110981a6bbb99dddbcdf8455f56a wpt-pr: 34741
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Per the spec change [1], this removes ErrorEventInit's default value of null, which makes the error attribute have no null default. This change has already shipped on WebKit and Gecko, and the change makes Chromium match the spec and other implementations. This is tested by this WPT: wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html [1] whatwg/html#7983 Fixed: 1332448 Change-Id: Ia64a62e8c5739ab278016a94b0c3b0419d6a68f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749784 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021841} NOKEYCHECK=True GitOrigin-RevId: 6f838d8a7333e27aec1d1036c9c3b9d7b5cd8b9f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that ErrorEvent has equivalent expressiveness to reportError().
Fixes #7853.
See whatwg/webidl#983 for why this removes the default and does not change it to be undefined.
As discussed during #7919.
(See WHATWG Working Mode: Changes for more details.)
/webappapis.html ( diff )