Use correct properties for meter element thickness #8536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 21, 2022
This CL allows <meter> element to have writing-mode vertical for the native appearance. Currently, Chrome doesn't render the <meter> element if appearance is set to none [1]. This change is under the flag FormControlsVerticalWritingModeSupport. Opened a github PR to update HTML spec [2]. [1] crbug.com/632510 [2] whatwg/html#8536 Change-Id: I68155f146b1608587ad4facb0918b9c054114976 Bug: 681917
domenic
approved these changes
Nov 22, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 22, 2022
This CL allows <meter> element to have writing-mode vertical for the native appearance. Currently, Chrome doesn't render the <meter> element if appearance is set to none [1]. This change is under the flag FormControlsVerticalWritingModeSupport. Opened a github PR to update HTML spec [2]. [1] crbug.com/632510 [2] whatwg/html#8536 Change-Id: I68155f146b1608587ad4facb0918b9c054114976 Bug: 681917
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 23, 2022
This CL allows <meter> element to have writing-mode vertical for the native appearance. Currently, Chrome doesn't render the <meter> element if appearance is set to none [1]. This change is under the flag FormControlsVerticalWritingModeSupport. Opened a github PR to update HTML spec [2]. [1] crbug.com/632510 [2] whatwg/html#8536 Change-Id: I68155f146b1608587ad4facb0918b9c054114976 Bug: 681917
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 29, 2022
This CL allows <meter> element to have writing-mode vertical for the native appearance. Currently, Chrome doesn't render the <meter> element if appearance is set to none [1]. This change is under the flag FormControlsVerticalWritingModeSupport. Opened a github PR to update HTML spec [2]. [1] crbug.com/632510 [2] whatwg/html#8536 Change-Id: I68155f146b1608587ad4facb0918b9c054114976 Bug: 681917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024368 Commit-Queue: Di Zhang <dizhangg@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076534}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 29, 2022
This CL allows <meter> element to have writing-mode vertical for the native appearance. Currently, Chrome doesn't render the <meter> element if appearance is set to none [1]. This change is under the flag FormControlsVerticalWritingModeSupport. Opened a github PR to update HTML spec [2]. [1] crbug.com/632510 [2] whatwg/html#8536 Change-Id: I68155f146b1608587ad4facb0918b9c054114976 Bug: 681917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024368 Commit-Queue: Di Zhang <dizhangg@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076534}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 29, 2022
This CL allows <meter> element to have writing-mode vertical for the native appearance. Currently, Chrome doesn't render the <meter> element if appearance is set to none [1]. This change is under the flag FormControlsVerticalWritingModeSupport. Opened a github PR to update HTML spec [2]. [1] crbug.com/632510 [2] whatwg/html#8536 Change-Id: I68155f146b1608587ad4facb0918b9c054114976 Bug: 681917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024368 Commit-Queue: Di Zhang <dizhangg@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076534}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 11, 2022
… vertical for native appearance, a=testonly Automatic update from web-platform-tests Allow Meter element to have writing mode vertical for native appearance This CL allows <meter> element to have writing-mode vertical for the native appearance. Currently, Chrome doesn't render the <meter> element if appearance is set to none [1]. This change is under the flag FormControlsVerticalWritingModeSupport. Opened a github PR to update HTML spec [2]. [1] crbug.com/632510 [2] whatwg/html#8536 Change-Id: I68155f146b1608587ad4facb0918b9c054114976 Bug: 681917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024368 Commit-Queue: Di Zhang <dizhangg@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076534} -- wpt-commits: 3765a636c09179bd0ba95bcecfd42be312a7ebc9 wpt-pr: 37056
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Dec 14, 2022
… vertical for native appearance, a=testonly Automatic update from web-platform-tests Allow Meter element to have writing mode vertical for native appearance This CL allows <meter> element to have writing-mode vertical for the native appearance. Currently, Chrome doesn't render the <meter> element if appearance is set to none [1]. This change is under the flag FormControlsVerticalWritingModeSupport. Opened a github PR to update HTML spec [2]. [1] crbug.com/632510 [2] whatwg/html#8536 Change-Id: I68155f146b1608587ad4facb0918b9c054114976 Bug: 681917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024368 Commit-Queue: Di Zhang <dizhangg@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076534} -- wpt-commits: 3765a636c09179bd0ba95bcecfd42be312a7ebc9 wpt-pr: 37056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Meter Element's description of how to render native appearance [1], we should use
block-size: 1eminstead ofheight: 1emandinline-size: 5eminstead ofwidth: 5em. This change will not affect existing behavior for horizontal writing mode (the specced behavior).(See WHATWG Working Mode: Changes for more details.)
The choice to support writing-mode is left to the UA [2]. Blink would like to enable writing-mode vertical for control forms, including the Meter element. The changes proposed in this PR will be correct for both writing mode vertical and horizontal. For more implementation details, see chromium CL [3].
Note: This change is similar to PR #8471, which was meant for the Progress element.
[1] https://html.spec.whatwg.org/multipage/rendering.html#the-meter-element-2
[2] https://drafts.csswg.org/css-ui-4/#appearance-switching:~:text=User%20agents%20may%20disregard%20some%20CSS%20properties%20on%20widgets%20rendered
[3] https://chromium-review.googlesource.com/c/chromium/src/+/4024368
/rendering.html ( diff )