Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user-agent style rules for top layer transitions #9387

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Jun 5, 2023

  1. Fix ::backdrop user-agent rule for popovers

    With the new css-position spec and overlay CSS property, it is possible
    for ::backdrop and its corresponding element with the popover attribute
    to be in the top layer while it is transitioning from showing to hidden.
    During this time, :popover-open does not apply but the element and
    ::backdrop are still in the top layer, but we still want our
    popover-specific user-agent style rules for ::backdrop to apply. This PR
    accomplishes this by moving the ::backdrop style rule from a stylesheet
    to a more specific definition.
    
    This was implemented in chromium by replacing the
    :popover-open::backdrop selector with an internal pseudo-selector.
    josepharhar committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    96d20f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    e432274 View commit details
    Browse the repository at this point in the history
  2. add dialog rules

    josepharhar committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    769e586 View commit details
    Browse the repository at this point in the history
  3. add references

    josepharhar committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    50afc38 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3c72d74 View commit details
    Browse the repository at this point in the history
  5. remove overlay rule

    josepharhar committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b68224e View commit details
    Browse the repository at this point in the history