-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hasUAVisualTransition attribute to popState and navigate event #9579
Conversation
This unfortunately is not how to specify this behavior. To do this, you need to properly initialize these attributes at each place that the events are fired. Those places are: |
This reverts commit 8ca26bc.
Done. I wasn't sure what to write when defining the attribute, seemed redundant to write the same explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just some polish work to do.
Done, ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to fix the line wrapping. With that, this is good to go.
Also, please feel free to add your name to the acknowledgments section if you'd like!
All merged! Please file an MDN issue when you get the chance, and update the OP for posterity to link to it. |
Fixes #8782
/acknowledgements.html ( diff )
/browsing-the-web.html ( diff )
/nav-history-apis.html ( diff )