Forbid data: and javascript: URLs in <base> #9665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correct a minor mistake in the invocation of "Is base allowed for Document?". Tests: web-platform-tests/wpt#41731. Fixes #2249.
zcorpan
approved these changes
Aug 31, 2023
domenic
reviewed
Sep 1, 2023
| allowed for Document?</span> on the <span>resulting URL record</span> and <var>document</var> | ||
| returns "<code data-x="">Blocked</code>", and to <var>urlRecord</var> otherwise.</p></li> | ||
| <li> | ||
| <p>If one of the following is true</p> |
There was a problem hiding this comment.
What if two of the following are true?
There was a problem hiding this comment.
I thought when we used this construct the "at least" was implicit. Because if two are true, one of them is also true.
There was a problem hiding this comment.
We usually say "if any of the following". I guess I will do a small PR to uniformize, since there are now 5 cases of "if one of".
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 13, 2023
…in the <base> element, a=testonly Automatic update from web-platform-tests HTML: forbid data: and javascript: URLs in the <base> element For whatwg/html#9665. -- wpt-commits: 5dc33b806b23771e0003a9c5aecbcfa04baddada wpt-pr: 41731
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Sep 14, 2023
…in the <base> element, a=testonly Automatic update from web-platform-tests HTML: forbid data: and javascript: URLs in the <base> element For whatwg/html#9665. -- wpt-commits: 5dc33b806b23771e0003a9c5aecbcfa04baddada wpt-pr: 41731
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correct a minor mistake in the invocation of "Is base allowed for Document?".
Tests: web-platform-tests/wpt#41731.
Fixes #2249.
(See WHATWG Working Mode: Changes for more details.)
/semantics.html ( diff )