Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commandfor & command attributes to HTMLButtonElement #9841

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Add commandfor & command attributes to HTMLButtonElement #9841

wants to merge 21 commits into from
+514 −72

Commits on Nov 8, 2024

  1. Add commandfor & command attributes to HTMLButtonElement 

    This adds the commandfor & command attributes and a "command" event using the CommandEvent interface.

Button activation checks if the button has a "commandfor" target and if so performs invoker command
behaviour depending on command and the target element.

This introduces 1 new IDLs:

- CommandEvent: A new event that has `action` and `source`.

And extends the HTMLButtonElement IDL to introduce `command` and
`commandfor`

Things NOT covered in this commit that are included in the proposal (whatwg#9625):

- Default per element behaviours for anything beyond popover & dialog,
  this will be dealt with in subsequent individual commits.

- `interestaction` and `interesttarget`.
    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ece6a7a View commit details
    Browse the repository at this point in the history

  2. fix indentation

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    449b84f View commit details
    Browse the repository at this point in the history

  3. s/and false otherwise/; otherwise false

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    25cb9bb View commit details
    Browse the repository at this point in the history

  4. remove undeeded comma

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8910fca View commit details
    Browse the repository at this point in the history

  5. move state outside span

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4787019 View commit details
    Browse the repository at this point in the history

  6. fix casing in state names

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6fa9256 View commit details
    Browse the repository at this point in the history

  7. drop definitions for attributes mapping to idl definitions 

    This was incorrect
    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1c64d6c View commit details
    Browse the repository at this point in the history

  8. use correct terms for popover show/hide (not open/close)

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d873b56 View commit details
    Browse the repository at this point in the history

  9. more s/, then://

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c2c2355 View commit details
    Browse the repository at this point in the history

  10. fix indentation

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    9392612 View commit details
    Browse the repository at this point in the history

  11. reintroduce accidentally removed line break

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ccc2d54 View commit details
    Browse the repository at this point in the history

  12. fixup broken definition for popover visibility state

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0ba5dd6 View commit details
    Browse the repository at this point in the history

  13. make commandForElement properly reflect the commandfor attribute

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1d2ad94 View commit details
    Browse the repository at this point in the history

  14. reintroduce the command attribute definition

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2afda9a View commit details
    Browse the repository at this point in the history

  15. type and simplify the various invoker command steps

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f734eb8 View commit details
    Browse the repository at this point in the history

  16. reintroduce the commandfor attribute definition

    @keithamus
    keithamus committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e3f9723 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. drop attribute reflection and use bespoke algorithms for command mapping

    @keithamus
    keithamus committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    cdd0b4d View commit details
    Browse the repository at this point in the history

  2. attempt to re-define submit button behavior with command/commandfor

    @keithamus
    keithamus committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    d897bd8 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. expand command getter steps into a list, always return string

    @keithamus
    keithamus committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    37b8ed3 View commit details
    Browse the repository at this point in the history

  2. expand type getter steps to ensure "submit" is only returned for vali… 

    …d submit buttons
    @keithamus
    keithamus committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    87d9efb View commit details
    Browse the repository at this point in the history

  3. remove duplicate statement

    @keithamus
    keithamus committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    88dd314 View commit details
    Browse the repository at this point in the history