Implement WebDriver BiDi interception in the show the picker algorithm
#9844
Conversation
There was a problem hiding this comment.
At least two implementers are interested (and none opposed):
Mozilla + Chromium:
this just links back to this PR. Do you have more concrete evidence of support?
Any plans for web platform tests?
https://w3c.github.io/webdriver-bidi/#webdriver-bidi-file-dialog-opened does not go anywhere currently; marking as "do not merge yet" until that appears.
| @@ -52390,7 +52391,11 @@ You cannot submit this form when the field is incorrect.</samp></pre> | |||
| <ol> | |||
| <li><p>Optionally, wait until any prior execution of this algorithm has terminated.</p></li> | |||
|
|
|||
| <li><p>Display a prompt to the user requesting that the user specify some files. If the <code | |||
| <li><p>Let <var>intercepted</var> be the result of <span>WebDriver BiDi file dialog opened</span> with <var>element</var></p></li> | |||
There was a problem hiding this comment.
Period at end of sentence. And rewrap to 100 chars using https://domenic.github.io/rewrapper/ .
|
|
||
| <li>If <var>intercepted</var> is true, then return.</li> | ||
|
|
||
| <li><p>Otherwise, display a prompt to the user requesting that the user specify some files. If the <code |
There was a problem hiding this comment.
No need to change this by introducing "Otherwise,"; it's after a "then return".
domenic
added
do not merge yet
|
Why does this only intercept the show picker algorithm for file inputs? Seems like it would be useful to test all the show picker algorithms? |
|
Gecko supports this. Tests are also required on the WebDriver side (which is defacto where this would be tested), and there's now a good track record of actually writing tests for those changes, so I personally don't think that this PR has to block on tests (although of course that's not my decision to make :) ) |
show the pickeralgorithm #9844(See WHATWG Working Mode: Changes for more details.)
CC: @jgraham @gsnedders
/infrastructure.html ( diff )
/input.html ( diff )