Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strict CSP #303

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Add strict CSP #303

merged 1 commit into from
Nov 2, 2022

Conversation

domenic
Copy link
Member

@domenic domenic commented Oct 3, 2022

Part of #296.

@domenic domenic requested a review from a team as a code owner October 3, 2022 03:43
Base automatically changed from no-details-shim to main November 2, 2022 01:55
annevk
annevk approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. This won't defend us from exfiltration or style XSS, but that's okay I suppose.

@domenic domenic merged commit d8310f5 into main Nov 2, 2022
@domenic domenic deleted the strict-csp branch November 2, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @annevk