Meta: update repository files #51
Conversation
foolip
force-pushed
the
meta-template/ffdd9f7c-8571-11ea-b445-82d5a4c81c00
branch
from
46e293b to
3f94207
Compare
|
I've updated this with the latest stuff for whatwg/meta#173. |
| @@ -4,13 +4,16 @@ root = true | |||
| end_of_line = lf | |||
| insert_final_newline = true | |||
| charset = utf-8 | |||
| indent_size = 1 | |||
| indent_size = 2 | |||
There was a problem hiding this comment.
This change should be fine because *.bs gets indent 1 below.
|
Filed w3c/csswg-drafts#5209 on the build issue. I wonder if we can surface the build failures in a better way as with GitHub Actions there's one more click to get to them. |
For anything associated with a line number we can do something pretty sweet, but we'd need speced/bikeshed#1686 fixed for it to be reliable. |
|
So per https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-error-message line/col are optional. If we omit those, will it still surface inline somehow? |
|
IIRC from my experiment, annotations for files that aren't touched would show up in the annotations list, much like the annotation for failure on this very PR: However, you don't see those unless you go looking. One could pretend that warnings/errors are on the first line of a file, of course. |
|
I see. I was hoping for information in the PR itself and failing that, information once you navigate to https://github.com/whatwg/quirks/pull/51/checks. But it seems you have to navigate there, then expand the failing step, and then maybe scroll, depending. |
|
It worked: https://quirks.spec.whatwg.org/ |
See https://github.com/whatwg/spec-factory for details.