Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MDN issue to PR template #28

Closed
domenic opened this issue Jul 27, 2021 · 4 comments · Fixed by #41
Closed

Add MDN issue to PR template #28

domenic opened this issue Jul 27, 2021 · 4 comments · Fixed by #41
Assignees

Comments

@domenic
Copy link
Member

domenic commented Jul 27, 2021

https://github.com/whatwg/spec-factory/blob/main/PULL_REQUEST_TEMPLATE.md.template should be updated with a new checklist item like:

- [ ] [MDN Issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed (if applicable): …

Then we need to update https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests to give the right instructions for documentation.

@sideshowbarker maybe you could work on the whatwg/meta changes first?

@sideshowbarker sideshowbarker self-assigned this Jul 28, 2021
@annevk
Copy link
Member

annevk commented Oct 7, 2021

@sideshowbarker did this drop of your radar?

@sideshowbarker
Copy link
Member

@sideshowbarker did this drop of your radar?

Apologies for having neglected it — just now opened whatwg/meta#226

sideshowbarker added a commit to whatwg/meta that referenced this issue Oct 8, 2021
@sideshowbarker
Copy link
Member

Apologies for having neglected it — just now opened whatwg/meta#226

Superseded by whatwg/meta#227

annevk added a commit to whatwg/meta that referenced this issue Oct 13, 2021
@annevk
Copy link
Member

annevk commented Oct 13, 2021

I merged that, do you want to PR spec-factory? I can probably review today and merge and deploy tomorrow (generates 17 - 1 PRs and I'm not sure I want to deal with that today).

annevk added a commit that referenced this issue Oct 12, 2022
sideshowbarker pushed a commit that referenced this issue Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants