Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abortReason property from WritableStream spec #1177

Merged
merged 15 commits into from
Oct 25, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update ref impl and webidl
nidhijaju committed Oct 18, 2021
commit 001d68a88bd6251b3881f8fd83f58f76ad6f9de8
Original file line number Diff line number Diff line change
@@ -5,9 +5,6 @@ const { AbortSteps, ErrorSteps } = require('./abstract-ops/internal-methods.js')
const { ResetQueue } = require('./abstract-ops/queue-with-sizes.js');

exports.implementation = class WritableStreamDefaultControllerImpl {
get abortReason() {
return this._abortReason;
}
get signal() {
return this._abortController.signal;
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[Exposed=(Window,Worker,Worklet)]
interface WritableStreamDefaultController {
readonly attribute any abortReason;
readonly attribute AbortSignal signal;
void error(optional any e);
};
2 changes: 0 additions & 2 deletions reference-implementation/lib/abstract-ops/writable-streams.js
Original file line number Diff line number Diff line change
@@ -107,7 +107,6 @@ function WritableStreamAbort(stream, reason) {
if (stream._state === 'closed' || stream._state === 'errored') {
return promiseResolvedWith(undefined);
}
stream._controller._abortReason = reason;
stream._controller._abortController.abort();
const state = stream._state;
if (state === 'closed' || state === 'errored') {
@@ -542,7 +541,6 @@ function SetUpWritableStreamDefaultController(stream, controller, startAlgorithm
controller._queueTotalSize = undefined;
ResetQueue(controller);

controller._abortReason = undefined;
controller._abortController = new AbortController();
controller._started = false;