Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the correct value that should be passed for processing_option? #400

Closed
TRowbotham opened this issue Jul 5, 2018 · 3 comments
Closed

Comments

@TRowbotham
Copy link
Contributor

In the domain to ASCII algorithm, it is explicitly stated that processing_option should be set to Nontransitional_Processing. However, the domain to Unicode algorithm does not explicitly state whether Transitional or Nontransitional processing should be used. Am I correct to assume that Transitional processing should be used here?

Let result be the result of running Unicode ToUnicode with domain_name set to domain, CheckHyphens set to false, CheckBidi set to true, CheckJoiners set to true, and UseSTD3ASCIIRules set to false.

The steps in valid domain also don't explicitly state which processing_option should be used. Am I correct to assume that Transitional processing is also used here?

Set result to the result of running Unicode ToUnicode with domain_name set to result, CheckHyphens set to false, CheckBidi set to true, CheckJoiners set to true, and UseSTD3ASCIIRules set to true.

@annevk
Copy link
Member

annevk commented Jul 21, 2018

I suspect this should be Nontransitional as well. The main problem with this algorithm in general is that it isn't exposed to script at the moment and what browsers implement is more complicated. See #274 for some past discussion.

@TRowbotham
Copy link
Contributor Author

Thanks for the clarification. I had read through all the idna labeled issues previously, but didn't really find an answer in them.

@TimothyGu
Copy link
Member

How interesting, the Transitional flag for ToUnicode was added in the most recent update. Previously, ToUnicode always used Nontransitional. We should replicate that behavior.

annevk pushed a commit that referenced this issue Jul 23, 2018
This makes it so that the domain to ASCII, domain to Unicode, and valid domain explicitly state the value for the *Transitional_Processing* flag as now required by UTS 46.

It also renames *processing_option* to *Transitional_Processing* to match UTS 46 changes. Fixes #400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants