Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate consolidating various URL component cloning operations #504

Closed
annevk opened this issue May 9, 2020 · 1 comment
Closed

Investigate consolidating various URL component cloning operations #504

annevk opened this issue May 9, 2020 · 1 comment
Labels
topic: parser

Comments

@annevk
Copy link
Member

annevk commented May 9, 2020

Searching for "clone" yields most of them.
annevk added a commit that referenced this issue May 10, 2020
@annevk
Editorial: deduplicate the relative state
e86c9d8 
Helps with #504.
@annevk annevk mentioned this issue May 10, 2020
Merged
annevk added a commit that referenced this issue May 11, 2020
@annevk
Editorial: attempt to deduplicate the file state
d54cc5e 
Maybe helps with #504, though this is much less convincing than #509 I think.

I also noticed there is not good coverage for file base URLs.
@annevk annevk mentioned this issue May 11, 2020
Merged
annevk added a commit that referenced this issue May 11, 2020
@annevk
Editorial: deduplicate the relative state
e5b1dd7 
Helps with #504.
annevk added a commit that referenced this issue May 14, 2020
@annevk
Editorial: deduplicate the file state
cb9c97f 
Helps a bit with #504 and possibly #302.
@annevk
Copy link
Member Author

annevk commented Dec 9, 2022

This looks reasonable now. Absent a concrete suggestion I'm not sure what more to do here.

@annevk annevk closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: parser
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annevk