-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "parse error" with "parse violation" #60
Comments
Perhaps just adding "and continue" or some other language to indicate that the algorithm "falls through" such a condition would be a more important clarification. |
I'm a bit stuck on how to satisfy @hillbrad's comment since we have many instances where we require that something is done, but don't want things to end. If we make it "report a syntax error" would that make it clearer that it doesn't terminate the parse operation? Note that the definition for parse error is clear on this already. |
I see the difficulty here. I wonder if there is room to introduce a On Fri, Aug 14, 2015 at 4:45 AM Anne van Kesteren notifications@github.com
|
Yeah, I think that's why @sideshowbarker suggested "violation". It's not clear to me that "warning" is strong enough since you are actually in error, at least, to the extent we keep caring about conformance. |
I think syntax violation is perfect in the context of the URL spec but I think optimally it would be good to have the same term for this “parse error” stuff across all specs, including the HTML spec. But in the HTML spec, since the treebuilder part (not just the tokenizer) also contains “parse error” cases, syntax violation may not be accurate for in all those cases. But I guess we can worry about what to change it to in the HTML spec if/when we ever actually get there. |
Yeah, I wonder what errors there would not be syntax violations, but I agree that if we find we need a different term we should revisit this. |
The spec should replace https://url.spec.whatwg.org/#parse-error with parse violation.
parse error is an ambiguous and misleading term. See #59 (comment) for background.
The text was updated successfully, but these errors were encountered: