Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: algorithms can now have default argument values #575

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Editorial: algorithms can now have default argument values #575

merged 3 commits into from
Feb 1, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 29, 2021 •
edited by pr-preview bot
Loading

Thanks Infra!

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Feb 1, 2021, 5:49 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@annevk annevk mentioned this pull request Jan 29, 2021
Merged
3 tasks
domenic
domenic reviewed Jan 29, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be <dfn for="algorithm name"> so that cross-linking from callers works. I think updating all the callers is a long project, but it'd be good to do the groundwork here ahead of time so that we can update over time.

url.bs Outdated Show resolved Hide resolved
@annevk annevk requested a review from domenic January 30, 2021 06:53
annevk
annevk commented Feb 1, 2021
View reviewed changes
url.bs Outdated Show resolved Hide resolved
annevk added a commit that referenced this pull request Feb 1, 2021
@annevk
Editorial: go all in on booleans
29ffc3e 
The reign of flags is over, except for IDs. Complements #575.
@annevk annevk mentioned this pull request Feb 1, 2021
Merged
domenic
domenic requested changes Feb 1, 2021
View reviewed changes
url.bs Show resolved Hide resolved
url.bs Show resolved Hide resolved
url.bs Show resolved Hide resolved
url.bs Show resolved Hide resolved
url.bs Show resolved Hide resolved
url.bs Outdated Show resolved Hide resolved
url.bs Outdated Show resolved Hide resolved
url.bs Show resolved Hide resolved
url.bs Outdated Show resolved Hide resolved
@annevk annevk requested a review from domenic February 1, 2021 17:49
@annevk annevk merged commit b8067b1 into main Feb 1, 2021
@annevk annevk deleted the annevk/default-parameter-values branch February 1, 2021 18:17
annevk added a commit that referenced this pull request Feb 2, 2021
@annevk
Editorial: go all in on booleans
b40eb97 
The reign of flags is over, except for IDs. Complements #575.
@whatwg whatwg deleted a comment Mar 22, 2021
@whatwg whatwg deleted a comment Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic