Document invariants of percent-encode sets better #896
Conversation
|
Side note: having this as a test in WPT could be helpful to ensure that impls didn't use the wrong test Upd: ah, there is a full-range test for form/url, it just doesn't cover userinfo, but that's likely unreachable |
Also give them a proper type. Fixes #895.
annevk
force-pushed
the
annevk/userinfo-backslash
branch
from
5c50135 to
e52054e
Compare
annevk
changed the title
|
That's a very good point. Which is probably also why I got the example wrong in the first place. I revised this PR with a more drastic change. |
url.bs
Outdated
| <td><a for=string>Percent-encode after encoding</a> with <a>Shift_JIS</a>, <var>input</var>, and | ||
| the <a><code>application/x-www-form-urlencoded</code> percent-encode set</a> | ||
| <td>"<code>1+1 ≡ 2%20‽</code>" | ||
| <td>"<code>1+1+%81%DF+2%20%26%238253%3B</code>" |
There was a problem hiding this comment.
application/x-www-form-urlencoded percent-encode set includes component percent-encode set which includes U+002B (+) and U+0025 (%)
- The first
+must be escaped (but not the second and third as they come from spaces) - The original
%is also escaped.
I get 1%2B1+%81%DF+2%2520%26%238253%3B in my impl
There was a problem hiding this comment.
Chrome also says 1%2B1+%81%DF+2%2520%26%238253%3B (pls recheck me)
There was a problem hiding this comment.
Oops, thanks for being on top of it! I double checked in Safari modulo the Shift_JIS aspect now.
There was a problem hiding this comment.
This thread is resolved / can be closed, I just don't have the button to label it as such.
| U+005B ([) to U+005D (]), inclusive, and U+007C (|). | ||
| <p>The <dfn oldids=userinfo-encode-set>userinfo percent-encode set</dfn> is a | ||
| <a>percent-encode set</a> consisting of the <a>path percent-encode set</a> and U+002F (/), | ||
| U+003A (:), U+003B (;), U+003D (=), U+0040 (@), U+005B ([) to U+005D (]), inclusive, and U+007C (|). |
There was a problem hiding this comment.
nit: this could have been explicit "5B, 5C, 5D" instead of "5B to 5D, inclusive"
that would make missing 5C less likely
| <p>The <dfn export>component percent-encode set</dfn> is the <a>userinfo percent-encode set</a> and | ||
| U+0024 ($) to U+0026 (&), inclusive, U+002B (+), and U+002C (,). | ||
| <p>The <dfn export>component percent-encode set</dfn> is a <a>percent-encode set</a> consisting of | ||
| the <a>userinfo percent-encode set</a> and U+0024 ($) to U+0026 (&), inclusive, U+002B (+), and |
There was a problem hiding this comment.
nit: same here, could make missing 25 less likely
| inclusive, and U+007E (~). | ||
| <p>The <dfn><code>application/x-www-form-urlencoded</code> percent-encode set</dfn> is a | ||
| <a>percent-encode set</a> consisting of the <a>component percent-encode set</a> and U+0021 (!), | ||
| U+0027 (') to U+0029 RIGHT PARENTHESIS, inclusive, and U+007E (~). |
|
Side note: I added more cross-tests |
2 participants
Fixes #895.