Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tracking-vector image in dark-mode #161

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fix tracking-vector image in dark-mode #161

merged 1 commit into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. fix tarcking-vector image in dark-mode 

    Since whatwg/whatwg.org#444 *tracking-vector.svg* is now darkmode-aware, i.e. its fill color will be dependent on the user's darkmode settings. However from whatwg/whatwg.org#439 `<img>` tags pointing at svg images that don't have a `"darkmode-aware"` class are given a white background by default. This makes the tracking-vector image fully white when seen in dark-mode.
This PR aims at fixing it by adding the class on the generated `<img>` element.

Note that I'm not entirely sure this is the only source for this image in all the specs, but I tested it with html-build where it already handles a bunch.
    @Kaiido
    Kaiido committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    72b942a View commit details
    Browse the repository at this point in the history