Ensure IDL blocks are omitted from the dev edition #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing wattsi code for causing IDL blocks to be omitted from the dev edition quit working when whatwg/html#3768 moved class=idl attributes off `pre` elements and instead onto to `code` children of those elements, So the first part of this change causes those `code class=idl` elements to be dropped as expected. But as a result of that, the now-empty `pre` element parents of those `code` elements are left behind. So the second part of this change looks for those empty `pre` elements and drops them. Fixes #84
domenic
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing wattsi code for causing IDL blocks to be omitted from the dev edition quit working when whatwg/html#3768 moved class=idl attributes off
preelements and instead onto tocodechildren of those elements,So the first part of this change causes those
code class=idlelements to be dropped as expected. But as a result of that, the now-emptypreelement parents of thosecodeelements are left behind. So the second part of this change looks for those emptypreelements and drops them.Fixes #84