WIP review draft deploy #201
Conversation
resources.whatwg.org/build/deploy.sh
Outdated
| for f in "$REVIEW_DRAFTS_DIR"/*.bs; do | ||
| [ -e "$f" ] || continue # http://mywiki.wooledge.org/BashPitfalls#line-80 | ||
| if [[ "$TRAVIS_PULL_REQUEST" == "true" ]]; then | ||
| CHANGED_FILES=$(git diff --name-only master..HEAD) |
There was a problem hiding this comment.
Since we put the DATE directly in the draft I don't think we need to distinguish between added and changed anymore. Hence we can simply use --name-only instead of --name-status.
I used master..HEAD here so a PR will consider all commits. We'll just have to ensure to land as a single commit on master.
resources.whatwg.org/build/deploy.sh
Outdated
| CHANGED_FILES=$(git diff --name-only HEAD~1) | ||
| fi | ||
| for change in "$CHANGED_FILES"; do | ||
| if [[ f != change ]]; then |
There was a problem hiding this comment.
Or should these variables be quoted again here? It's also a little unclear to me when to user lowercase and when to use uppercase for variables.
resources.whatwg.org/build/deploy.sh
Outdated
| BASENAME=$(basename "$f" .bs) | ||
| DRAFT_DIR="$WEB_ROOT/$REVIEW_DRAFTS_DIR/$BASENAME" | ||
| mkdir -p "$DRAFT_DIR" | ||
| curlbikeshed -F md-Status="RD" \ |
There was a problem hiding this comment.
Nah, since we're already in the WHATWG org, just the status suffices.
resources.whatwg.org/build/deploy.sh
Outdated
| for f in "$REVIEW_DRAFTS_DIR"/*.bs; do | ||
| [ -e "$f" ] || continue # http://mywiki.wooledge.org/BashPitfalls#line-80 | ||
| if [[ "$TRAVIS_PULL_REQUEST" == "true" ]]; then | ||
| CHANGED_FILES=$(git diff --name-only master..HEAD) |
resources.whatwg.org/build/deploy.sh
Outdated
| BASENAME=$(basename "$f" .bs) | ||
| DRAFT_DIR="$WEB_ROOT/$REVIEW_DRAFTS_DIR/$BASENAME" | ||
| mkdir -p "$DRAFT_DIR" | ||
| curlbikeshed -F md-Status="RD" \ |
There was a problem hiding this comment.
Nah, since we're already in the WHATWG org, just the status suffices.
resources.whatwg.org/build/deploy.sh
Outdated
| else | ||
| CHANGED_FILES=$(git diff --name-only HEAD~1) | ||
| fi | ||
| for change in $CHANGED_FILES; do # Omit quotes around variable to split on whitespace |
There was a problem hiding this comment.
FWIW we should probably stick to uppercase everywhere, I was just copying and pasting from places that did lowercase.
resources.whatwg.org/build/review.sh
Outdated
| INPUT_FILE=$(find . -maxdepth 1 -name "*.bs" -print -quit) | ||
| REVIEW_DRAFT="review-drafts/$(date +'%Y-%m').bs" | ||
| # The very unusual way of creating a newline here is done to keep macOS happy | ||
| sed 's/^Group: WHATWG$/&'''$'\n'"Date: $(date +'%Y-%m-%d')/g" < "$INPUT_FILE" > "$REVIEW_DRAFT" |
There was a problem hiding this comment.
I tried running this locally and got sed: -e expression #1, char 19: unterminated `s' command which is probably about this line. Using sed (GNU sed) 4.4.
There was a problem hiding this comment.
Hmm, I suspect the various versions of sed are incompatible in their syntaxes. What matters most is that this works on Travis, which we haven't really tried yet. But it does pass shellcheck apparently.
There was a problem hiding this comment.
I think ''' also does not work on macOS. \' did work.
|
While working on whatwg/html-build#151 I found a number of issues with the approach here. Will try to fix. |
See #197 and whatwg/sg#70.
This doesn't yet prevent re-building and deploying; discussions ongoing in #197.