Enable specs to deploy using GitHub Actions #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
force-pushed
the
github-actions-spec-deploy
branch
from
be706b1 to
57739f0
Compare
25 tasks
domenic
approved these changes
Jun 11, 2020
| - master | ||
| jobs: | ||
| deploy: | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
We've been using Debian elsewhere; any particular reason to go with Ubuntu here?
There was a problem hiding this comment.
https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners#supported-runners-and-hardware-resources is the set of GitHub-provided runners. We could provide our own Docker image and lock everything down, but I actually think it's not necessary for the relatively plain dependencies that we have.
foolip
force-pushed
the
github-actions-spec-deploy
branch
from
57739f0 to
eb0de3f
Compare
|
I fixed the shellcheck failure (missing quotes) and rebased. When I've merged this and it's deployed to resources.whatwg.org, I'll merge whatwg/fullscreen#174 to see if I broke the existing Travis builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of whatwg/meta#173.