Skip to content
This repository has been archived by the owner on Jan 2, 2025. It is now read-only.

Add custom file output path for settings.xml #111

Closed
zteater opened this issue Jun 7, 2021 · 1 comment · Fixed by #112 or #115
Closed

Add custom file output path for settings.xml #111

zteater opened this issue Jun 7, 2021 · 1 comment · Fixed by #112 or #115
Labels
enhancement New feature or request maven-settings-xml-action Project name

Comments

@zteater
Copy link
Contributor

zteater commented Jun 7, 2021

I dumped the settings.xml generated by maven-settings-xml-action then copied the content to the test file in the repo.
I did some formatting for readability, otherwise it is the generated content including ${env.DEPLOY_USER_REF}.
When using that with --settings Maven again does not attempt to decrypt and it works!

I hope this is not a formatting issue.

Would it be possible to extend this action with the possibility to write the file somewhere else - keeping the default as it is for compatibility?
I write somewhere in the github workspace and then pass it to Maven.

Originally posted by @robertklaus-bosch in #97 (reply in thread)
@zteater zteater added enhancement New feature or request maven-settings-xml-action Project name labels Jun 7, 2021
zteater added a commit that referenced this issue Jun 8, 2021
@zteater
add custom filepath to input options, fixes #111
60e10aa
@zteater zteater linked a pull request Jun 9, 2021 that will close this issue
Allow custom filename for output file #112
Merged
zteater added a commit that referenced this issue Jun 14, 2021
@zteater
Allow custom filename for output file (#112)
81bcd26 
* add custom filepath to input options, fixes #111

* update transitive dependency to clear new vulnerability

* add basic maven application for testing build, fixes #114
@zteater zteater mentioned this issue Jun 14, 2021
Merged
@zteater
Copy link
Contributor Author

zteater commented Jun 14, 2021

Added to release v18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request maven-settings-xml-action Project name
Projects
None yet
Milestone
No milestone
1 participant
@zteater