Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Storybook default args #120

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix Storybook default args #120

merged 1 commit into from
Nov 8, 2023

Conversation

havardholvik
Copy link
Collaborator

The new Storybook version handles default arguments differently from the previous. This fixes the issue.

Tested like

  1. Do yarn dev with .env file including STORYBOOK_ROOM=<your_room>
  2. Verify the correct room is being used when connecting

@havardholvik
Fix Storybook default args
e88439a 
The new Storybook version handles default arguments differently from the
previous. This fixes the issue.
kevinwhereby
kevinwhereby approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@kevinwhereby kevinwhereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 🍰

nandito
nandito approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@nandito nandito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me too. Sorry for not fixing this when I upgraded Storybook 😞

@havardholvik havardholvik merged commit 935a6d2 into development Nov 8, 2023
2 checks passed
@havardholvik havardholvik deleted the havard/pan-507-fix-env-variables-not-working-in-storybook branch November 8, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwhereby kevinwhereby kevinwhereby approved these changes

@nandito nandito nandito approved these changes

@thyal thyal Awaiting requested review from thyal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@havardholvik @nandito @kevinwhereby