Add Core SDK export for Node client #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwhereby
force-pushed
the
kevinhanna/test-node-core-export
branch
from
8483ba2 to
656fe73
Compare
nandito
reviewed
Jan 3, 2024
nandito
reviewed
Jan 3, 2024
havardholvik
force-pushed
the
development
branch
from
7b6413d to
f9fffef
Compare
kevinwhereby
force-pushed
the
kevinhanna/test-node-core-export
branch
from
656fe73 to
6b4acc9
Compare
kevinwhereby
force-pushed
the
kevinhanna/test-node-core-export
branch
7 times, most recently
from
f5bc5b6 to
930e8b7
Compare
kevinwhereby
changed the title
kevinwhereby
commented
Jan 26, 2024
| @@ -24,6 +24,7 @@ import { | |||
| import { rtcAnalyticsCustomEvents, rtcEvents } from "./actions"; | |||
| import { StreamStatusUpdate } from "./types"; | |||
| import { signalEvents } from "../signalConnection/actions"; | |||
| import { Chrome111 as MediasoupDeviceHandler } from "mediasoup-client/lib/handlers/Chrome111"; | |||
There was a problem hiding this comment.
turns out the msc-node handler just didn't work. This one does, so we can use it for now and look at how that might break stuff...
kevinwhereby
commented
Jan 26, 2024
kevinwhereby
force-pushed
the
kevinhanna/test-node-core-export
branch
from
930e8b7 to
49bf55b
Compare
kevinwhereby
force-pushed
the
kevinhanna/test-node-core-export
branch
from
49bf55b to
122d25f
Compare
kevinwhereby
force-pushed
the
kevinhanna/test-node-core-export
branch
3 times, most recently
from
da02560 to
9dedcc2
Compare
sebapawlak
approved these changes
Jan 30, 2024
kevinwhereby
force-pushed
the
kevinhanna/test-node-core-export
branch
from
9dedcc2 to
70056ae
Compare
also add an option to disable local media, as our client is receive only
I've updated jslib-media to support passing a custom deviceHandlerFactory, so when the SDK is running in Node we should tell jslib-media to use whatever one works best (chrome111 for now)
kevinwhereby
force-pushed
the
kevinhanna/test-node-core-export
branch
from
313f5fc to
d6af9a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.