Merge development branch #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now the recorder and streamer clients have been excluded only when they joined after the participants were in the meeting using SDK. This fix excludes those non-person clients from the remote participant list when the a participant joins a meeting that has a recording/stream in progress already.
SFU can return the streams in the requiested size, so no need to download a bigger resolution if the video view is small.
* break long lines into multiple lines; * decrease the heading level of the Usage with Next.js section * fix typo in the Next.js usage section
Define event listeners in an array and add them via a loop instead of adding them one by one. This will make it easier to remove event listeners in a hook cleanup.
This breaks the app currently as it uses another unresolved dep. Removing it from the `nodeResolve` fn makes the test React apps work with the SDK. However Vite apps are going to break. But they're broken without this change too. Related PR: #60
The recent addition of screenshare support led to a regression in p2p rooms, where remote participant video went missing. This fixes issue #72
esbuild doesn't support generating type declarations like rollup doesn This is a little problematic, as now we have a separate build step that tells tsc to generate our types. tsc doesn't support generating a single index.d.ts file for es6 modules, so we emit our directory structure.
This is a basic react app that uses the Browser SDK.
* fix: localMediaSlice bug * Add sendStatsCustomEvent to rtc manager interface * Add reactor for rtc analytics custom events * Add screenshare button to storybook * Task: tidy customEvents object expression
Incorporate the latest embed element changes before merging into main.
This story needs to be converted to React before it can be used.
sebapawlak
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are edging even closer to v2, so lets get this in now to get it over the line.