Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation works but is error-prone since we just write out action type strings. This means whenever an action creator changes name this list would need to be manually updated, and it's too easy to miss that.
This PR use the action creators directly, and rely on the
isAnyOf
helper to match on actions.Depends on #186 because I did some changes to the action creators there.
Summary:
Related Issue:
Testing
Test that the rtc events are still sent. Use #175 test plan.
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Dependency Updates
Reviewers
@havardholvik
@kevinwhereby
@nandito
@thyal
Additional Information