Skip to content

export more core types and test helper utils #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

kevinwhereby
Copy link
Contributor

Description

I'm starting to write tests for the transcription-client and felt these could come in handy.

We interact directly when using the /core export, so exporting a helper to create a mock store is very useful
The participant types are also useful

Testing

this is just exports, so as long as you can import them we are golden

Checklist

  • My code follows the project's coding standards.
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

@kevinwhereby kevinwhereby changed the base branch from main to development January 31, 2024 12:11
@kevinwhereby kevinwhereby force-pushed the kevinhanna/export-types-and-test-helpers branch from 3a7c75a to 84b7893 Compare January 31, 2024 12:12
@kevinwhereby kevinwhereby force-pushed the kevinhanna/export-types-and-test-helpers branch from 84b7893 to 2f553db Compare February 1, 2024 09:02
@kevinwhereby kevinwhereby force-pushed the kevinhanna/export-types-and-test-helpers branch from bde3e95 to 8fc8643 Compare February 1, 2024 10:20
@sebapawlak sebapawlak self-requested a review February 1, 2024 10:25
also move RoomParticipant into the core module
@kevinwhereby kevinwhereby force-pushed the kevinhanna/export-types-and-test-helpers branch from 8fc8643 to 6ac1fce Compare February 1, 2024 10:28
@kevinwhereby kevinwhereby merged commit abb8f1d into development Feb 1, 2024
@kevinwhereby kevinwhereby deleted the kevinhanna/export-types-and-test-helpers branch February 1, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants