Reverses offer/answer role on sld failure #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geirbakke
force-pushed
the
geirbakke/cob-372-reverse-answeroffer-role-on-p2p-if-the-first-direction-fails
branch
from
28f22f3 to
752926a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverses the offer/answer role when we fail to set local description from offer generated. We will run this as an experiment to see if it can help some users on buggy(?) devices/browsers.
📦 Published PR as canary version:
1.8.1--canary.69.7887303967.0✨ Test out this PR locally via:
npm install @whereby/jslib-media@1.8.1--canary.69.7887303967.0 # or yarn add @whereby/jslib-media@1.8.1--canary.69.7887303967.0