Remove fps24 option from getMediaConstraints #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandito
force-pushed
the
nandor/cob-381-remove-24fps-flag
branch
from
9ad2729
to
ee86eb6
Compare
This fps24 is always on in pwa now, so this constant `true` arg can be replaced with a default 24 fps in code.
nandito
force-pushed
the
nandor/cob-381-remove-24fps-flag
branch
from
ee86eb6
to
039995b
Compare
misi
suggested changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was added here: #37
But now it is enabled for everyone, so it's value can be hard coded and the option can be removed.
📦 Published PR as canary version:
1.9.6--canary.82.8062035262.0✨ Test out this PR locally via:
npm install @whereby/jslib-media@1.9.6--canary.82.8062035262.0 # or yarn add @whereby/jslib-media@1.9.6--canary.82.8062035262.0