Merge pull request #397 from whereby/kevinhanna/close-rtc-stats-on-ap…

…p-stop

core: Close rtcstats connection when App is stopped

.changeset/dull-ants-hammer.md

@@ -0,0 +1,6 @@
+---
+"@whereby.com/core": minor
+"@whereby.com/media": patch
+---
+
+Close RtcStats connection when App is stopped

packages/core/src/redux/slices/rtcConnection/index.ts

@@ -12,7 +12,7 @@ import { selectSignalConnectionRaw, selectSignalConnectionSocket, socketReconnec
 import { createReactor, startAppListening } from "../../listenerMiddleware";
 import { selectRemoteClients, streamStatusUpdated } from "../remoteParticipants";
 import { StreamState } from "../../../RoomParticipant";
-import { selectAppIsNodeSdk, selectAppIsActive } from "../app";
+import { selectAppIsNodeSdk, selectAppIsActive, doAppStop } from "../app";
 import { Chrome111 as MediasoupDeviceHandler } from "mediasoup-client/lib/handlers/Chrome111.js";
 import {
     selectIsCameraEnabled,
@@ -342,6 +342,15 @@ startAppListening({
     },
 });
 
+startAppListening({
+    actionCreator: doAppStop,
+    effect: (_, { getState }) => {
+        const rtcManager = selectRtcManager(getState());
+
+        rtcManager?.rtcStatsDisconnect();
+    },
+});
+
 startAppListening({
     actionCreator: stopScreenshare,
     effect: ({ payload }, { getState }) => {

packages/core/src/redux/tests/store.setup.ts

@@ -19,6 +19,7 @@ export const mockRtcManager = {
     removeStream: jest.fn(),
     disconnect: jest.fn(),
     disconnectAll: jest.fn(),
+    rtcStatsDisconnect: jest.fn(),
     updateStreamResolution: jest.fn(),
     sendStatsCustomEvent: jest.fn(),
 };

packages/core/src/redux/tests/store/rtcConnection.spec.ts

@@ -5,13 +5,15 @@ import {
     doDisconnectRtc,
     doRtcReportStreamResolution,
     doRtcManagerInitialize,
+    selectRtcManager,
 } from "../../slices/rtcConnection";
 import { randomRemoteParticipant, randomString } from "../../../__mocks__/appMocks";
 import MockMediaStream from "../../../__mocks__/MediaStream";
 import { RtcManagerDispatcher } from "@whereby.com/media";
 import { initialLocalMediaState } from "../../slices/localMedia";
 import { diff } from "deep-object-diff";
 import { coreVersion } from "../../../version";
+import { doAppStop } from "../../slices/app";
 
 jest.mock("@whereby.com/media");
 
@@ -163,3 +165,18 @@ describe("actions", () => {
         expect(store.getState().rtcConnection.rtcManagerInitialized).toBe(true);
     });
 });
+
+describe("middleware", () => {
+    describe("doAppStop", () => {
+        it("closes the rtcstats connection", () => {
+            const store = createStore({
+                withRtcManager: true,
+            });
+            const rtcManager = selectRtcManager(store.getState());
+
+            store.dispatch(doAppStop());
+
+            expect(rtcManager?.rtcStatsDisconnect).toHaveBeenCalled();
+        });
+    });
+});

packages/media/src/webrtc/types.ts

@@ -14,17 +14,18 @@ export interface RtcManager {
         clientId,
         shouldAddLocalVideo,
         streamId,
-        enforceTurnProtocol
+        enforceTurnProtocol,
     }: {
         activeBreakout: boolean;
         clientId: string;
         shouldAddLocalVideo: boolean;
         streamId: string;
-        enforceTurnProtocol?: TurnTransportProtocol
+        enforceTurnProtocol?: TurnTransportProtocol;
     }) => void;
     addNewStream(streamId: string, stream: MediaStream, isAudioEnabled: boolean, isVideoEnabled: boolean): void;
     disconnect(streamId: string, activeBreakout: boolean | null, eventClaim?: string): void;
     disconnectAll(): void;
+    rtcStatsDisconnect(): void;
     replaceTrack(oldTrack: CustomMediaStreamTrack, newTrack: CustomMediaStreamTrack): void;
     removeStream(streamId: string, _stream: MediaStream, requestedByClientId: string | null): void;
     shouldAcceptStreamsFromBothSides?: () => boolean;