Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser-sdk: update exports to use default name rather than import #280

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

remotezygote
Copy link

@remotezygote remotezygote commented May 24, 2024

Description

Summary:

Similar to this issue in next-auth: nextauthjs/next-auth#8330

The exports as situated do not work with all bundlers/resolvers.

Related Issue:

n/a

Testing

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 9443b25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@whereby.com/browser-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remotezygote remotezygote changed the title Update exports to use default name rather than import browser-sdk: update exports to use default name rather than import May 30, 2024
fuo213 and others added 4 commits May 30, 2024 13:10
Co-authored-by: Richard Tibbett <119658286+richtrwhereby@users.noreply.github.com>
Co-authored-by: Richard Tibbett <119658286+richtrwhereby@users.noreply.github.com>
Similar to this issue in next-auth: nextauthjs/next-auth#8330

The exports as situated do not work with all bundlers/resolvers.
@thyal
Copy link
Member

thyal commented Jun 27, 2024

Hey 👋

Thanks for the PR!
Sorry for the delay on this. The pipelines are not set up to work with forks of the repository, that's why this PR is failing. I'm going to look in to that + create a contribution guide. We do want to welcome contributions!

For now though, I just merged #307 , which was aimed at a different problem, but I also added the default export field there. It's released in v3.3.0. Let me know if that fixes the problem for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants