common: Add new component UI library #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d9c9b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thyal
force-pushed
the
thomas/PAN-1135-maximize-participants
branch
2 times, most recently
from
c4590e9
to
1fcfa6b
Compare
kevinwhereby
force-pushed
the
thomas/PAN-1157-component-ui-library
branch
3 times, most recently
from
4c62ad5
to
597827f
Compare
kevinwhereby
force-pushed
the
thomas/PAN-1157-component-ui-library
branch
from
597827f
to
2d9c9b2
Compare
| @@ -92,4 +125,19 @@ const spacing = { | |||
| 10: "192px", | |||
| }; | |||
|
|
|||
| export { colors, fontWeights, fontSizes, lineHeights, borderRadius, dropShadow, spacing }; | |||
| const useTheme = () => { | |||
| const theme = useEmotionTheme(); | |||
There was a problem hiding this comment.
not sure how themes with the css prop will work in cases where there's no emotion provider
Maybe we can just avoid using it
<Thing css={(theme) => ???}/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release new
react-uicomponent library, and use it inbrowser-sdk. It's pretty minimal at the moment, with only a couple of icons, andAvatarandPopovercomponents.Summary:
Related Issue:
Testing
yarn build && yarn devScreenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information