Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported is-subset-of package #871

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ottenhoff
Copy link

No description provided.

@ottenhoff ottenhoff changed the title Remove deprecated is-subset-of package Remove unsupported is-subset-of package Nov 13, 2024
@wheresrhys
Copy link
Owner

wheresrhys commented Nov 15, 2024

Thanks for doing this. I'm not too sure about accepting it as it is though. is-subset-of implements a lot more behaviour than your implementation, so there's a chance that this change could introduce some breaking changes. Also there are no tests, so even the subset of the previous behaviour that's been implemented might contain bugs. Previously I could get away with not writing detailed tests as I documented that I used a specific library, so users could look there for docs & issues, but if I'm to bring an implementation into this repo then it becomes my responsibility.

Do you know of any libraries that implement something like is-subset-of. If had a quick look around and can't find any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants