Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write musicbrainz_discid tag when disc is unknown #280

Closed
xmixahlx opened this issue Jul 22, 2018 · 6 comments
Closed

Write musicbrainz_discid tag when disc is unknown #280

xmixahlx opened this issue Jul 22, 2018 · 6 comments
Labels
Accepted Accepted issue on our roadmap Feature New feature
Milestone

Comments

@xmixahlx
Copy link

xmixahlx commented Jul 22, 2018

whipper writes the the (useless...) title, artist and album tag fields when the disc is Unknown, but does not write the musicbrainz_id tag field, which would be rather useful.

I resolve this by adding the tag in Ex Falso manually, but it would be nice to avoid hunting down the value and avoid copy+paste errors.

FYI to fix Unknown Disc details: I rename the files, then use a "Tags From Path" formula and "Edit Tags" to review/fix/add. Similar naming and tagging functionality would be nice in whipper.

@JoeLametta
Copy link
Collaborator

Thanks for proposing this feature.
There are lots of musicbrainz_ tags:

musicbrainz_trackid
musicbrainz_releasetrackid
musicbrainz_artistid
musicbrainz_albumid
musicbrainz_albumartistid
musicbrainz_discid
musicbrainz_originalartistid
musicbrainz_originalalbumid
musicbrainz_recordingid
musicbrainz_workid
musicbrainz_releasegroupid

Which one(s) exactly are you asking for inclusion?

Related to #200.

@Freso
Copy link
Member

Freso commented Sep 17, 2018

If the disc is otherwise unknown, the only MusicBrainz related ID that makes sense to add is the musicbrainz_discid. All the other depend on the disc being known.

@JoeLametta
Copy link
Collaborator

If the disc is otherwise unknown, the only MusicBrainz related ID that makes sense to add is the musicbrainz_discid. All the other depend on the disc being known.

Understood, thanks!

@JoeLametta
Copy link
Collaborator

JoeLametta commented Nov 2, 2018

I think it makes sense to always add the musicbrainz_discid tag (not only when the disc is unknown).

EDIT: 🤦‍♂️ It gets already added (only missing when unknown)

@JoeLametta JoeLametta changed the title Write musicbrainz_id tag field when disc is Unknown Write musicbrainz_discid tag Nov 2, 2018
@JoeLametta JoeLametta changed the title Write musicbrainz_discid tag Write musicbrainz_discid tag when disc is unknown Nov 2, 2018
@JoeLametta JoeLametta added this to the 1.0 milestone Nov 2, 2018
JoeLametta added a commit that referenced this issue Nov 2, 2018
@Freso
Copy link
Member

Freso commented Nov 2, 2018

EDIT: 🤦‍♂️ It gets already added (only missing when unknown)

Since thomasvs/morituri#77 - yes. ;)

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Feature New feature and removed enhancement labels Nov 12, 2018
@JoeLametta
Copy link
Collaborator

@Freso, @MerlijnWajer I think this Google Code-In task should be closed (already completed). 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants