Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate warning "eject: CD-ROM tray close command failed" #354

Closed
edrozenberg opened this issue Jan 14, 2019 · 2 comments · Fixed by #408
Closed

Eliminate warning "eject: CD-ROM tray close command failed" #354

edrozenberg opened this issue Jan 14, 2019 · 2 comments · Fixed by #408
Assignees
@JoeLametta
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Design Design or UX/UI related Priority: low Low priority Sprintable Small enough to sprint on
Milestone
0.8.0

Comments

@edrozenberg
Copy link

I receive the following error/warning when starting a rip:

eject: CD-ROM tray close command failed: Input/output error

I assume this is because my drive is a push-to-close tray instead of a motorized close tray?

Should whipper not display these warnings/errors since they are innocuous and expected for push-to-close trays?

For reference my drive is a Toshiba SuperMultiPA3761.
@welcome
Copy link

welcome bot commented Jan 14, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@JoeLametta JoeLametta added Bug Generic bug: can be used together with more specific labels Accepted Accepted issue on our roadmap Priority: low Low priority Design Design or UX/UI related Sprintable Small enough to sprint on labels Jan 17, 2019
@JoeLametta
Copy link
Collaborator

I assume this is because my drive is a push-to-close tray instead of a motorized close tray?

Correct.

Should whipper not display these warnings/errors since they are innocuous and expected for push-to-close trays?

This can certainly be improved: I've labelled this issue as a low priority bug. 😉

@JoeLametta JoeLametta self-assigned this Jan 20, 2019
@JoeLametta JoeLametta added this to the 1.0 milestone Jan 20, 2019
@JoeLametta JoeLametta changed the title Eliminate warning "eject: CD-ROM tray close command failed" ? Eliminate warning "eject: CD-ROM tray close command failed" Jan 20, 2019
JoeLametta added a commit that referenced this issue Jul 7, 2019
@JoeLametta
Report eject's failures as logger warnings
e5961ae 
If the eject command exits with an error, the output is logged as a WARNING. I don't think it's a good idea to mask those errors.

Closes #354.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
@JoeLametta JoeLametta mentioned this issue Jul 7, 2019
Merged
@JoeLametta JoeLametta added the Status: in progress Issue/pull request which is currently being worked on label Jul 7, 2019
@JoeLametta JoeLametta modified the milestones: 1.0, 0.8.0 Oct 21, 2019
@JoeLametta JoeLametta removed the Status: in progress Issue/pull request which is currently being worked on label Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeLametta JoeLametta

Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Design Design or UX/UI related Priority: low Low priority Sprintable Small enough to sprint on
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Report eject's failures as logger warnings whipper-team/whipper
2 participants
@edrozenberg @JoeLametta