Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to limit drive speed #473

Closed
unkissedfrog opened this issue Mar 7, 2020 · 5 comments
Closed

Add option to limit drive speed #473

unkissedfrog opened this issue Mar 7, 2020 · 5 comments
Labels
Accepted Accepted issue on our roadmap Duplicate Duplicate of another issue Feature New feature Priority: medium Medium priority
Milestone

Comments

@unkissedfrog
Copy link

Dear all,

I love to reduce the drive speed for ripping audio CDs e.g. with hdparm -E. I noticed whipper to ignore this setting. The reading TOC process works fine with the reduced speed but when it comes to read/compare the tracks, my drive spins up again and gets noisy.
I verified this with all my drives.

Can you help please? Or can you add an option to set the drive speed with whipper?

Thanks for help

@JoeLametta
Copy link
Collaborator

Hi, whipper currently relies on two programs in order to rip CDs:

  1. cdrdao (toc extraction)
  2. cd-paranoia (audio ripping)

It seems you're saying that cdrdao does respec the drive speed set through hdparm while cd-paranoia doesn't. If that's correct you could try asking @rocky if there's a way to let cd-paranoia automatically detect and obey to that limit.
Another solution would be adding an option to whipper to limit the maximum drive speed. The user provided value would then be propagated both to cdrdao and cd-paranoia.

cdrdao setting:

--rspeed <read-speed>   - selects reading speed

cd-paranoia setting:

-S --force-read-speed number
        Use this option explicitly to set the read rate of the CD drive
        (where supported).  This can reduce underruns on machines with
        slow disks, or which are low on memory.

@JoeLametta JoeLametta added the Feature New feature label Mar 7, 2020
@rocky
Copy link

rocky commented Mar 7, 2020

Some information on libcdio-paranoia...

In contrast to cdparanoia, cd-paranoia relies on GNU libcdio for anything hardware related; non-libcdio code in cd-paranoia is the more algorithmically-oriented and hardware-independent parts where it looks for jitter by analyzing sound data that comes back, looking for silence or blank gaps in that.

I just looked at the libcdio API and there is nothing in there for detecting speed across the OS's that is supported, only setting the speed. If the CD-ROM drive supports the MMC-command set (which is supposed to be a "standard") then it might come back and tell you what the manufacter has decided the speed is, if the manufacture has added a "profile" for that feature. The profile information is optional. And even here, as it says in the cdparanoia FAQ:

Note that CD 'playback speed' is an excellent example of advertisers making numbers lie for them.

Given this, although this may sound self serving, the best thing to do would be for the speed to be passed along to cd-paranoia.

@unkissedfrog
Copy link
Author

I think adding an "force drive speed" option to whipper would be great and very welcome!

I just played around with the cdparanoia -S setting and my drive does not spin up so it seems to respect this flag.

@JoeLametta JoeLametta added the Accepted Accepted issue on our roadmap label Mar 22, 2020
@JoeLametta JoeLametta added this to the 2.0 milestone Mar 22, 2020
@JoeLametta
Copy link
Collaborator

JoeLametta commented Mar 22, 2020

@rocky Thanks for the reply!

I think adding an "force drive speed" option to whipper would be great and very welcome!

I agree and I'm going to change the title of the issue to reflect this.

@JoeLametta JoeLametta changed the title Drive speed settings are ignored by whipper Add option to limit drive speed Mar 22, 2020
@JoeLametta JoeLametta added the Priority: medium Medium priority label Mar 22, 2020
@JoeLametta JoeLametta added the Duplicate Duplicate of another issue label May 16, 2021
@JoeLametta
Copy link
Collaborator

Duplicate of #204: I'm closing this one. Let's continue the discussion in the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Duplicate Duplicate of another issue Feature New feature Priority: medium Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants