-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rip out all code that uses gstreamer #130
Merged
JoeLametta
merged 5 commits into
whipper-team:master
from
MerlijnWajer:remove-gstreamer
Apr 23, 2017
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e776769
Rip out all code that directly uses gstreamer
MerlijnWajer 304c668
Fix several issues in the gstreamer removal PR
MerlijnWajer 3526a24
Add peaktask to morituri/command/debug.py
MerlijnWajer efd75ab
EncodeTaskFlac -> FlacEncodeTask
MerlijnWajer 3fbe7f4
Remove dependency on gst from the README.
MerlijnWajer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ | |
from morituri.common import accurip, common, config, drive, program | ||
from morituri.common import task as ctask | ||
from morituri.program import cdrdao, cdparanoia, utils | ||
from morituri.common import checksum | ||
|
||
from morituri.extern.task import task | ||
|
||
|
@@ -209,8 +210,6 @@ def _arcs(self, runner, table, track, offset): | |
track, offset) | ||
runner.run(t) | ||
|
||
# here to avoid import gst eating our options | ||
from morituri.common import checksum | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe also remove this empty line? |
||
# TODO MW: Update this to also use the v2 checksum(s) | ||
t = checksum.FastAccurateRipChecksumTask(path, trackNumber=track, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also remove this empty line?