Resolve case where _peakdB is None #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates a peak of 0)
…Result.peak to a float.
|
@chadberg Thanks for reporting the issue and providing a fix: merged! |
JoeLametta
added a commit
that referenced
this pull request
Feb 2, 2016
Resolve case where _peakdB is None
|
No problem, glad to help. For anyone looking at the original repo, this was issue #100 ( ticket 122 in the trac ticket tracker) going all the way back to v 0.2.0. Cancelled merge request #19 when I realized the problem went deeper than needing to cast an int to a float. Rerunning rip cd rip would work because once the track 0 was extracted, running the command a second time would skip over that track and proceed where it left off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When _peakdB is none (sometimes happens with HTOA), peak is not set to a float number, causing the output to crash with a TypeError: a float is required on line 434 of cd.py. This pull request will fix this (and changes the strings in this section of cd.py to use the newer str.format convention).